This repository has been archived by the owner on Mar 24, 2020. It is now read-only.
Add generic thumbnail and restricted view info to search objects view #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcritchlow
reviewed
May 1, 2018
| <%= link_to url, :class => 'dams-search-thumbnail-link' do %> | ||
| <%- if !restrictedNotice.nil? && rtn = restricted_object_url%> | ||
| <div class="document-thumbnail dams-search-thumbnail"> | ||
| <%= rtn %> | ||
| </div> | ||
| <%- elsif access_notice && rtn = restricted_object_url%> |
There was a problem hiding this comment.
How hard would it be to have a helper function that returns the URL we want for the link? We've got 3 branches here that all render the same div with the same classes and then the link. I'm just wondering if we could pull the logic out so the link_to is basically just the div with the returned value from a method that sorts out the correct URL. If that's a pain, then no worries! Just a thought.
|
@mcritchlow - I created a helper method for the url. Could you review them again? Thanks |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #411 ; refs #411
Add grey generic thumbnails and restricted view access info for objects of metadata data-only visibility collections.
@ucsdlib/developers - please review