Fixes - #270 Implemented mapping from DAMS4 to SHARE V2 API and updat… #450

hweng · 2018-05-14T22:39:27Z

…ed push function.

Fixes #270 ; refs #270

@ucsdlib/developers - please review

…ed push function.

houndci-bot · 2018-05-14T22:39:44Z

lib/dams/controller_helper.rb

 		  }
 		  json_data = {"jsonData": field_map}
-		end
+		end    
+


Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2018-05-14T22:39:44Z

lib/dams/controller_helper.rb

 		  }
 		  json_data = {"jsonData": field_map}
-		end
+		end    


Layout/Tab: Tab detected.
Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2018-05-14T22:39:44Z

lib/dams/controller_helper.rb

 		    'tags': osf_mads_fields(document),
-		    'publisher': osf_publisher
+		    'ertra': osf_extra(document)


Layout/Tab: Tab detected.

houndci-bot · 2018-05-14T22:39:44Z

lib/dams/controller_helper.rb

 		    'languages': osf_languages(document),
-		    'providerUpdatedDateTime': osf_date(document),
+		    'date_published': osf_date_published(document),


Layout/Tab: Tab detected.

houndci-bot · 2018-05-14T22:39:44Z

lib/dams/controller_helper.rb

 		def export_to_API(document)
 		  field_map = {
 		    'title': osf_title(document),
 		    'description': osf_description(document),
-		    'contributor': osf_contributors(document),
-		    'uris': osf_uris(document),
+		    'related_agents': osf_related_agents(document),


Layout/Tab: Tab detected.

houndci-bot · 2018-05-14T22:39:45Z

lib/dams/controller_helper.rb


 			if dams_data != nil
-				url = "http://library.ucsd.edu/dc/collection/#{dams_data}"
-		    osf_data = {"canonicalUri": url, "providerUris": url}
+		    dams_data.each do |datum|


Layout/Tab: Tab detected.
Layout/IndentationWidth: Use 2 (not 3) spaces for indentation.

houndci-bot · 2018-05-14T22:39:45Z

lib/dams/controller_helper.rb

 			dams_data = document["#{field_name}"]
-			osf_data = {}
+			osf_data = ''


Layout/Tab: Tab detected.

houndci-bot · 2018-05-14T22:39:45Z

lib/dams/controller_helper.rb

-		def osf_uris(document)
-			field_name = "id"
+		def osf_description(document)
+			field_name = "otherNote_json_tesim"


Layout/Tab: Tab detected.
Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-05-14T22:39:45Z

lib/dams/controller_helper.rb

 		    end
 		  end
 		  osf_data
 		end 

-		def osf_uris(document)
-			field_name = "id"
+		def osf_description(document)


Layout/Tab: Tab detected.

houndci-bot · 2018-05-14T22:39:45Z

lib/dams/controller_helper.rb


 			if dams_data != nil
 		    dams_data.each do |datum|
 		      other_note = JSON.parse(datum)
-		      osf_data = other_note['value'] if other_note['type'] == 'description'
+		      osf_data = { funding: other_note['value'] } if other_note['type'] == 'funding'


Layout/Tab: Tab detected.

houndci-bot · 2018-05-14T22:53:56Z

lib/dams/controller_helper.rb

 		  }
 		  json_data = {"jsonData": field_map}
 		end

-# Retrieve label from solr index instead of external record from repo
+		# Retrieve label from solr index instead of external record from repo


Layout/Tab: Tab detected.
Layout/CommentIndentation: Incorrect indentation detected (column 2 instead of 1).

houndci-bot · 2018-05-14T22:53:56Z

lib/dams/controller_helper.rb

 			dams_data = document["#{field_name}"]
-			osf_data = {}
+			osf_data = ''


Layout/Tab: Tab detected.
Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-05-14T22:53:57Z

lib/dams/controller_helper.rb

-		def osf_uris(document)
-			field_name = "id"
+		def osf_description(document)
+		  field_name = "otherNote_json_tesim"


Layout/Tab: Tab detected.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-05-14T22:53:57Z

lib/dams/controller_helper.rb

 		    end
 		  end
 		  osf_data
-		end 
+		end


Layout/Tab: Tab detected.

houndci-bot · 2018-05-14T23:07:10Z

lib/dams/controller_helper.rb

+				dams_data.each do |datum|
+		      other_note = JSON.parse(datum)
+		      osf_data = other_note['value'] if other_note['type'] == 'description'
+		    end


Layout/Tab: Tab detected.
Layout/BlockAlignment: end at 123, 6 is not aligned with dams_data.each do |datum| at 120, 4.

houndci-bot · 2018-05-14T23:07:10Z

lib/dams/controller_helper.rb


 			if dams_data != nil
-				url = "http://library.ucsd.edu/dc/collection/#{dams_data}"
-		    osf_data = {"canonicalUri": url, "providerUris": url}
+				dams_data.each do |datum|


Layout/Tab: Tab detected.
Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.

houndci-bot · 2018-05-14T23:07:10Z

lib/dams/controller_helper.rb


-		def osf_uris(document)
-			field_name = "id"
+		def osf_description(document)


Layout/Tab: Tab detected.

houndci-bot · 2018-05-14T23:07:10Z

lib/dams/controller_helper.rb

 			field_name = "otherNote_json_tesim"
 			dams_data = document["#{field_name}"]
-			osf_data = ''
+			osf_data = {}


Layout/Tab: Tab detected.

coveralls · 2018-05-14T23:42:49Z

Coverage decreased (-0.2%) to 66.037% when pulling 34a234a on feature/SHARE2_mapping into 92300c3 on develop.

houndci-bot · 2018-05-15T17:49:13Z

lib/dams/controller_helper.rb

 		  end
 		  osf_data
-		end
+		end 


Layout/Tab: Tab detected.
Layout/DefEndAlignment: end at 126, 2 is not aligned with def at 114, 4.
Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2018-05-15T17:49:13Z

lib/dams/controller_helper.rb

-		    osf_data = {"canonicalUri": url, "providerUris": url}
+        dams_data.each do |datum|
+		      other_note = JSON.parse(datum)
+		      osf_data = other_note['value'] if other_note['type'] == 'description'


Layout/Tab: Tab detected.

houndci-bot · 2018-05-15T17:49:14Z

lib/dams/controller_helper.rb

-				url = "http://library.ucsd.edu/dc/collection/#{dams_data}"
-		    osf_data = {"canonicalUri": url, "providerUris": url}
+        dams_data.each do |datum|
+		      other_note = JSON.parse(datum)


Layout/Tab: Tab detected.
Layout/IndentationWidth: Use 2 (not 0) spaces for indentation.

houndci-bot · 2018-05-15T17:49:14Z

lib/dams/controller_helper.rb


 			if dams_data != nil
-				url = "http://library.ucsd.edu/dc/collection/#{dams_data}"
-		    osf_data = {"canonicalUri": url, "providerUris": url}
+        dams_data.each do |datum|


Layout/IndentationWidth: Use 2 (not 5) spaces for indentation.

houndci-bot · 2018-05-15T17:49:14Z

lib/dams/controller_helper.rb

+    def osf_description(document)
+      field_name = "otherNote_json_tesim"
+		  dams_data = document["#{field_name}"]
+    	osf_data = ''


Layout/Tab: Tab detected.
Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-05-15T17:49:14Z

lib/dams/controller_helper.rb

-			dams_data = document["#{field_name}"]
-			osf_data = {}
+    def osf_description(document)
+      field_name = "otherNote_json_tesim"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-05-15T17:49:14Z

lib/dams/controller_helper.rb

-			field_name = "id"
-			dams_data = document["#{field_name}"]
-			osf_data = {}
+    def osf_description(document)


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-05-15T17:49:14Z

lib/dams/controller_helper.rb

 		  end
 		  osf_data
-		end 
+    end


Layout/DefEndAlignment: end at 112, 4 is not aligned with def at 100, 2.

houndci-bot · 2018-05-15T17:49:14Z

lib/dams/controller_helper.rb

-		      osf_data = other_note['value'] if other_note['type'] == 'description'
-		    end
+          osf_data = { funding: other_note['value'] } if other_note['type'] == 'funding'
+        end


Layout/BlockAlignment: end at 109, 8 is not aligned with dams_data.each do |datum| at 106, 6.

houndci-bot · 2018-05-15T17:49:14Z

lib/dams/controller_helper.rb


 			if dams_data != nil
 		    dams_data.each do |datum|
 		      other_note = JSON.parse(datum)
-		      osf_data = other_note['value'] if other_note['type'] == 'description'
-		    end
+          osf_data = { funding: other_note['value'] } if other_note['type'] == 'funding'


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-05-15T17:49:15Z

lib/dams/controller_helper.rb

 		  end
 		  osf_data
-		end
+		end 


Layout/Tab: Tab detected.
Layout/DefEndAlignment: end at 126, 2 is not aligned with def at 114, 4.
Layout/TrailingWhitespace: Trailing whitespace detected.

houndci-bot · 2018-05-15T17:49:15Z

lib/dams/controller_helper.rb

-		    osf_data = {"canonicalUri": url, "providerUris": url}
+        dams_data.each do |datum|
+		      other_note = JSON.parse(datum)
+		      osf_data = other_note['value'] if other_note['type'] == 'description'


Layout/Tab: Tab detected.

houndci-bot · 2018-05-15T17:49:15Z

lib/dams/controller_helper.rb

-				url = "http://library.ucsd.edu/dc/collection/#{dams_data}"
-		    osf_data = {"canonicalUri": url, "providerUris": url}
+        dams_data.each do |datum|
+		      other_note = JSON.parse(datum)


Layout/Tab: Tab detected.
Layout/IndentationWidth: Use 2 (not 0) spaces for indentation.

houndci-bot · 2018-05-15T17:49:15Z

lib/dams/controller_helper.rb


 			if dams_data != nil
-				url = "http://library.ucsd.edu/dc/collection/#{dams_data}"
-		    osf_data = {"canonicalUri": url, "providerUris": url}
+        dams_data.each do |datum|


Layout/IndentationWidth: Use 2 (not 5) spaces for indentation.

houndci-bot · 2018-05-15T17:49:15Z

lib/dams/controller_helper.rb

+    def osf_description(document)
+      field_name = "otherNote_json_tesim"
+		  dams_data = document["#{field_name}"]
+    	osf_data = ''


Layout/Tab: Tab detected.
Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-05-15T17:49:16Z

lib/dams/controller_helper.rb

-			dams_data = document["#{field_name}"]
-			osf_data = {}
+    def osf_description(document)
+      field_name = "otherNote_json_tesim"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-05-15T17:49:16Z

lib/dams/controller_helper.rb

-			field_name = "id"
-			dams_data = document["#{field_name}"]
-			osf_data = {}
+    def osf_description(document)


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-05-15T17:49:16Z

lib/dams/controller_helper.rb

 		  end
 		  osf_data
-		end 
+    end


Layout/DefEndAlignment: end at 112, 4 is not aligned with def at 100, 2.

houndci-bot · 2018-05-15T17:49:16Z

lib/dams/controller_helper.rb

-		      osf_data = other_note['value'] if other_note['type'] == 'description'
-		    end
+          osf_data = { funding: other_note['value'] } if other_note['type'] == 'funding'
+        end


Layout/BlockAlignment: end at 109, 8 is not aligned with dams_data.each do |datum| at 106, 6.

houndci-bot · 2018-05-15T17:49:16Z

lib/dams/controller_helper.rb


 			if dams_data != nil
 		    dams_data.each do |datum|
 		      other_note = JSON.parse(datum)
-		      osf_data = other_note['value'] if other_note['type'] == 'description'
-		    end
+          osf_data = { funding: other_note['value'] } if other_note['type'] == 'funding'


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-05-15T18:18:30Z

lib/dams/controller_helper.rb

+		    end
+		  end
+		  osf_data
+		end


Layout/Tab: Tab detected.

houndci-bot · 2018-05-15T18:18:30Z

lib/dams/controller_helper.rb

+		      osf_data = { funding: other_note['value'] } if other_note['type'] == 'funding'
+		    end
+		  end
+		  osf_data


Layout/Tab: Tab detected.
Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-05-15T18:18:30Z

lib/dams/controller_helper.rb

+		      other_note = JSON.parse(datum)
+		      osf_data = { funding: other_note['value'] } if other_note['type'] == 'funding'
+		    end
+		  end


Layout/Tab: Tab detected.
Layout/EndAlignment: end at 109, 4 is not aligned with if at 104, 3.

houndci-bot · 2018-05-15T18:18:30Z

lib/dams/controller_helper.rb

+		    dams_data.each do |datum|
+		      other_note = JSON.parse(datum)
+		      osf_data = { funding: other_note['value'] } if other_note['type'] == 'funding'
+		    end


Layout/Tab: Tab detected.

houndci-bot · 2018-05-15T18:18:30Z

lib/dams/controller_helper.rb

+			if dams_data != nil
+		    dams_data.each do |datum|
+		      other_note = JSON.parse(datum)
+		      osf_data = { funding: other_note['value'] } if other_note['type'] == 'funding'


Layout/Tab: Tab detected.

houndci-bot · 2018-05-15T18:18:31Z

lib/dams/controller_helper.rb

+			dams_data = document["#{field_name}"]
+			osf_data = {}
+
+			if dams_data != nil


Layout/Tab: Tab detected.
Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

houndci-bot · 2018-05-15T18:18:31Z

lib/dams/controller_helper.rb

+		def osf_extra(document)
+			field_name = "otherNote_json_tesim"
+			dams_data = document["#{field_name}"]
+			osf_data = {}


Layout/Tab: Tab detected.

houndci-bot · 2018-05-15T18:18:31Z

lib/dams/controller_helper.rb

+
+		def osf_extra(document)
+			field_name = "otherNote_json_tesim"
+			dams_data = document["#{field_name}"]


Layout/Tab: Tab detected.
Style/UnneededInterpolation: Prefer to_s over string interpolation.

houndci-bot · 2018-05-15T18:18:31Z

lib/dams/controller_helper.rb

+		end
+
+		def osf_extra(document)
+			field_name = "otherNote_json_tesim"


Layout/Tab: Tab detected.
Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-05-15T18:18:31Z

lib/dams/controller_helper.rb

+       type = (share_agent_type.include? type) ? type : "Contributor"
+		end
+
+		def osf_extra(document)


Layout/Tab: Tab detected.

houndci-bot · 2018-05-15T18:30:58Z

lib/dams/controller_helper.rb

 		    'tags': osf_mads_fields(document),
-		    'publisher': osf_publisher
+		    'extra': osf_extra(document)


Layout/Tab: Tab detected.

houndci-bot · 2018-05-15T18:30:58Z

lib/dams/controller_helper.rb

@@ -70,7 +135,7 @@ def osf_uris(document)
 		  osf_data
 		end

-		def osf_date(document)
+		def osf_date_published(document)


Layout/Tab: Tab detected.

houndci-bot · 2018-05-15T18:30:58Z

lib/dams/controller_helper.rb

+		      other_note = JSON.parse(datum)
+		      osf_data = { funding: other_note['value'] } if other_note['type'] == 'funding'
+		    end
+		  end


Layout/Tab: Tab detected.
Layout/EndAlignment: end at 108, 4 is not aligned with if at 103, 3.

houndci-bot · 2018-05-15T18:30:59Z

lib/dams/controller_helper.rb

+			dams_data = document["#{field_name}"]
+			osf_data = {}
+
+			if dams_data != nil


Layout/Tab: Tab detected.
Style/NonNilCheck: Prefer !expression.nil? over expression != nil.

houndci-bot · 2018-05-15T18:30:59Z

lib/dams/controller_helper.rb

+
+		def osf_extra(document)
+			field_name = 'otherNote_json_tesim'
+			dams_data = document["#{field_name}"]


Layout/Tab: Tab detected.
Style/UnneededInterpolation: Prefer to_s over string interpolation.

houndci-bot · 2018-05-15T18:30:59Z

lib/dams/controller_helper.rb

+		end
+
+		def osf_extra(document)
+			field_name = 'otherNote_json_tesim'


Layout/Tab: Tab detected.
Layout/IndentationWidth: Use 2 (not 1) spaces for indentation.

houndci-bot · 2018-05-15T18:30:59Z

lib/dams/controller_helper.rb

+      type = (share_agent_type.include? type) ? type : "Contributor"
+		end
+
+		def osf_extra(document)


Layout/Tab: Tab detected.

houndci-bot · 2018-05-15T19:50:11Z

lib/dams/controller_helper.rb

+          end
+        end
+
+      def metadata_display?(data)


Layout/IndentationConsistency: Inconsistent indentation detected.

houndci-bot · 2018-05-15T19:50:11Z

lib/dams/controller_helper.rb

+            begin
+              ref = Rails.application.routes.recognize_path(uri.path.gsub(/^\/dc/,""))
+              ref[:controller]
+            rescue Exception => e


Lint/RescueException: Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?

houndci-bot · 2018-05-15T19:50:12Z

lib/dams/controller_helper.rb

+          uri = URI(request.referrer || "")
+          if uri.host == request.host
+            begin
+              ref = Rails.application.routes.recognize_path(uri.path.gsub(/^\/dc/,""))


Layout/SpaceAfterComma: Space missing after comma.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-05-15T19:50:12Z

lib/dams/controller_helper.rb

+        # parse a request's referrer and figure out which controller it came from
+        def referrer_controller( request )
+          uri = URI(request.referrer || "")
+          if uri.host == request.host


Style/GuardClause: Use a guard clause instead of wrapping the code inside a conditional expression.

houndci-bot · 2018-05-15T19:50:12Z

lib/dams/controller_helper.rb

+
+        # parse a request's referrer and figure out which controller it came from
+        def referrer_controller( request )
+          uri = URI(request.referrer || "")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

houndci-bot · 2018-05-15T19:50:13Z

lib/dams/controller_helper.rb

+           res.body
+        end
+
+        def get_data ( recursive = true, format )


Layout/IndentationConsistency: Inconsistent indentation detected.
Layout/SpaceAfterMethodName: Do not put a space between a method name and the opening parenthesis.
Layout/SpaceInsideParens: Space inside parentheses detected.
Style/OptionalArguments: Optional arguments should appear at the end of the argument list.

houndci-bot · 2018-05-15T19:50:13Z

lib/dams/controller_helper.rb

+        def get_html_data ( params, controller_path )
+           xsl = (params[:xsl].nil? || params[:xsl].empty?)?'review.xsl':params[:xsl]
+           controller = (controller_path.nil? || controller_path.empty?)?'':'&controller=' + URI.encode(controller_path)
+           viewerUrl = "#{dams_api_path}/api/objects/#{params[:id]}/transform?recursive=true&xsl=#{xsl}&baseurl=" + URI.encode(dams_api_path) + controller


Naming/VariableName: Use snake_case for variable names.
Lint/UriEscapeUnescape: URI.encode method is obsolete and should not be used. Instead, use CGI.escape, URI.encode_www_form or URI.encode_www_form_component depending on your specific use case.
Metrics/LineLength: Line is too long. [154/150]

houndci-bot · 2018-05-15T19:50:13Z

lib/dams/controller_helper.rb

-  end
+        def get_html_data ( params, controller_path )
+           xsl = (params[:xsl].nil? || params[:xsl].empty?)?'review.xsl':params[:xsl]
+           controller = (controller_path.nil? || controller_path.empty?)?'':'&controller=' + URI.encode(controller_path)


Style/TernaryParentheses: Omit parentheses for ternary conditions.
Rails/Blank: Use controller_path.blank? instead of controller_path.nil? || controller_path.empty?.
Layout/SpaceAroundOperators: Surrounding space missing for operator ?.
Layout/SpaceAroundOperators: Surrounding space missing for operator :.
Lint/UriEscapeUnescape: URI.encode method is obsolete and should not be used. Instead, use CGI.escape, URI.encode_www_form or URI.encode_www_form_component depending on your specific use case.

houndci-bot · 2018-05-15T19:50:13Z

lib/dams/controller_helper.rb

-    result
-  end
+        def get_html_data ( params, controller_path )
+           xsl = (params[:xsl].nil? || params[:xsl].empty?)?'review.xsl':params[:xsl]


Layout/IndentationWidth: Use 2 (not 3) spaces for indentation.
Style/TernaryParentheses: Omit parentheses for ternary conditions.
Rails/Blank: Use params[:xsl].blank? instead of params[:xsl].nil? || params[:xsl].empty?.
Layout/SpaceAroundOperators: Surrounding space missing for operator ?.
Layout/SpaceAroundOperators: Surrounding space missing for operator :.

houndci-bot · 2018-05-15T19:50:13Z

lib/dams/controller_helper.rb

-    end
-    result
-  end
+        def get_html_data ( params, controller_path )


Layout/IndentationConsistency: Inconsistent indentation detected.
Layout/SpaceAfterMethodName: Do not put a space between a method name and the opening parenthesis.
Layout/SpaceInsideParens: Space inside parentheses detected.

Fixes - #270 Implemented mapping from DAMS4 to SHARE V2 API and updat…

11da2dc

…ed push function.

houndci-bot reviewed May 14, 2018

View reviewed changes

Fixing houndci-bot issues.

3191610

houndci-bot reviewed May 14, 2018

View reviewed changes

Fixing houndci-bot issues.

b699353

houndci-bot reviewed May 14, 2018

View reviewed changes

Fixing houndci-bot issues.

b3b1f42

houndci-bot reviewed May 15, 2018

View reviewed changes

Fixing houndci-bot issues.

94438b6

houndci-bot reviewed May 15, 2018

View reviewed changes

Fixing houndci-bot issues.

34a234a

houndci-bot reviewed May 15, 2018

View reviewed changes

Fix houndci-bot rubocop offensive

dc37ab5

houndci-bot reviewed May 15, 2018

View reviewed changes

hweng closed this May 17, 2018

hweng deleted the feature/SHARE2_mapping branch May 17, 2018 20:17

Fixes - #270 Implemented mapping from DAMS4 to SHARE V2 API and updat… #450

Fixes - #270 Implemented mapping from DAMS4 to SHARE V2 API and updat… #450

Conversation

hweng commented May 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented May 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented May 14, 2018 •

edited

Loading