This repository has been archived by the owner on Mar 24, 2020. It is now read-only.
Add secureToken function #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add securetoken test Update tests Fix failed test Change the end time
mcritchlow
approved these changes
May 30, 2018
app/helpers/dams_objects_helper.rb
Outdated
| file_name = grab_file_name(field_data, cmp_id) | ||
| return nil unless file_name | ||
| obj_path = obj_id.scan(/.{1,2}/).join('/') | ||
| "#{base_url}#{obj_path}/20775-#{obj_id}-#{file_name}".html_safe |
There was a problem hiding this comment.
This is a little nitpicky, but I'm wondering about having 20775 hardcoded here (and I think I saw it in one or two other places too. Should we put this in a config file or a one line method? I think the title for this would be something like ark_naan making an acronym out of Name Assigning Authority Number
app/helpers/dams_objects_helper.rb
Outdated
| # @return string or nil | ||
| #--- | ||
|
|
||
| def grab_file_name(field_data, cmp_id) |
There was a problem hiding this comment.
is this used for non audio-video files? It seems specifically a look up for them. If so, maybe the name of the method should indicate that?
|
@mcritchlow - The code has been updated. Could you review them again? Thanks |
|
LGTM 👍 |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #448 ; refs #448
@ucsdlib/developers - please review