This repository has been archived by the owner on Mar 24, 2020. It is now read-only.
Circle and docker #482
Merged
Circle and docker #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now use local postgres and tomcat (damsrepo/solr) containers instead of depending on pontos
Using Docker and Docker Compose, we can now run a localized development environment that will mirror the CircleCI testing environment. Please see docker/README.md for setup instructions
|
@ucsdlib/developers - Just an update, thanks to @lsitu for testing, I think this PR may be good to go now. If anyone else has any concerns please let me know, otherwise I think it would be nice to start leveraging this from the mainline branch soon if we can. Thanks! |
|
👍 |
1 similar comment
|
👍 |
|
@mcritchlow Nice to have docker for damspas! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #481
Local Checklist
masterbranch?What does this PR do?
This PR does 2 things.
It updates the CircleCI config file to use the custom damsrepo and postgres Docker images that I've created instead of pontos.
It creates a Docker-based dev/test environment that can be used locally instead of dams-vagrant
Dockerfilefor damspas/dockerdocker-compose.ymlfile for creating an environment that builds and runs containers for damspas, damsrepo, postgres, and solrWhy are we doing this? Any context of related work?
References #481
Where should a reviewer start?
docker/README.mdfor some notes on how to setup the dev environment. If anyone is up for giving it a try locally that would be great.Database changes
Deployment Instructions
docker/README.mdfor local dev setup@ucsdlib/developers - please review