This repository has been archived by the owner on Mar 24, 2020. It is now read-only.
Support multiple docker-compose environments #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The work entails the following: - Switching to use solr from a Docker container - Replacing the old, incorrect solr configuration with what we use in production - Creating two docker-compose options for running damspas under docker, see docker/README.md - Update circleci to use docker/ci/docker-compose.yml
|
👍 |
CircleCI image that must be used for the machine executor has an out of date ruby, but it is a 2.3 image, so the specs pass. Agreed to temporarily mark pending
|
@ucsdlib/developers - Just a note that in order to set this up cleanly I had to update the damsrepo image to remove Solr, which is now in the main image that CircleCI will pull. Which may mean other PR/builds might fail until we get this merged. It depends on how circleci does its caching, I'm not sure.. Not to rush anyone's review and the eventual merge of this, but wanted to make you all aware. |
|
👍 |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #495
Local Checklist
masterbranch?What does this PR do?
The work entails the following:
production
see docker/README.md
Why are we doing this? Any context of related work?
References #495
Where should a reviewer start?
Please look at the
docker/README.mdfile. In particular, if you all can run the dev/docker-compose.yml file and let me know if everything works and passes for you that would be great. If any of the documentation seems lacking, please let me know.Also it may be worth doing a
docker system pruneas noted in that README if you've been testing the other Docker work so far. It should help ensure you have a clean build environment.@ucsdlib/developers - please review