This repository has been archived by the owner on Mar 24, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
rdcp created date sorting (Collections) and last modified date display (Objects) #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b60232
to
43f7990
Compare
43f7990
to
4b7f890
Compare
5bc5a3a
to
f6f4f91
Compare
f6f4f91
to
ef7cc25
Compare
The last modified date is: - Only shown on object views (not collections) - Formatted to YYYY-MM-DD see: #643
ef7cc25
to
b49284f
Compare
lsitu
approved these changes
Aug 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 . @mcritchlow Please create a release ticket for damsrepo for the dependency as well once we are ready to release it. Thanks.
:+1 |
👍 |
@lsitu - That's a great point. In fact, just to make sure I don't forget I'll setup a WIP version now to start documenting what we'll need to do in production for this upcoming deploy. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: please don't merge until @lsitu and I have been able to test this out w/ stakeholders in QA. This PR is up as an FYI for now.Fixes #643
Fixes #644
Local Checklist
master
branch?What does this PR do?
Why are we doing this? Any context of related work?
References #643 #644
Screenshots
Last Modified date on Object view:
@ucsdlib/developers - please review