Skip to content
This repository has been archived by the owner on Mar 24, 2020. It is now read-only.

rdcp created date sorting (Collections) and last modified date display (Objects) #681

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

mcritchlow
Copy link
Member

@mcritchlow mcritchlow commented Jul 10, 2019

WIP: please don't merge until @lsitu and I have been able to test this out w/ stakeholders in QA. This PR is up as an FYI for now.

Fixes #643
Fixes #644

Note: These are grouped into a single PR (separate commits) because they both depend on a new implementation of created and modified dates as discussed in ucsdlib/damsrepo#92

Local Checklist

  • Tests written and passing locally?
  • Code style checked?
  • QA-ed locally?
  • Rebased with master branch?
  • Configuration updated (if needed)?
  • Documentation updated (if needed)?

What does this PR do?

  • Sorts by created date for RDCP collections by default
  • Adds a Last Modified Date to the DAMS Object view (only)
Why are we doing this? Any context of related work?

References #643 #644

Screenshots

Last Modified date on Object view:

pic-selected-190710-1258-37

@ucsdlib/developers - please review

@coveralls
Copy link

coveralls commented Jul 10, 2019

Coverage Status

Coverage increased (+0.03%) to 66.004% when pulling b49284f on feature/rdcp-sorting into 9023608 on master.

@mcritchlow mcritchlow changed the title WIP: rdcp sorting and last modified date (Objects) WIP: rdcp created date sorting (Collections) and last modified date display (Objects) Jul 10, 2019
@mcritchlow mcritchlow force-pushed the feature/rdcp-sorting branch 2 times, most recently from 5bc5a3a to f6f4f91 Compare July 17, 2019 19:27
The last modified date is:
- Only shown on object views (not collections)
- Formatted to YYYY-MM-DD

see: #643
@mcritchlow mcritchlow changed the title WIP: rdcp created date sorting (Collections) and last modified date display (Objects) rdcp created date sorting (Collections) and last modified date display (Objects) Aug 2, 2019
Copy link
Member

@lsitu lsitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . @mcritchlow Please create a release ticket for damsrepo for the dependency as well once we are ready to release it. Thanks.

@hweng
Copy link
Contributor

hweng commented Aug 2, 2019

:+1

@hweng hweng merged commit 337d668 into master Aug 2, 2019
@hweng hweng deleted the feature/rdcp-sorting branch August 2, 2019 23:04
@VivianChu
Copy link
Member

👍

@mcritchlow
Copy link
Member Author

@lsitu - That's a great point. In fact, just to make sure I don't forget I'll setup a WIP version now to start documenting what we'll need to do in production for this upcoming deploy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants