fix: some test code cause 200 response to be unsuccessful #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, some request test has code like this:
resp['status'] != '301':
raise Exception('Received an unsuccessful status code of %s' % resp['status']).
This will cause successful response falls into the exception because resp['status']='200'
|
This is the same with #9 |
|
+1 for this pull request, please merge it in! |
|
Definitely think this should be merged. It's not readily apparent that 301 status codes should be returned in this problem without reading the test code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, some request test has code like this:
resp['status'] != '301':
raise Exception('Received an unsuccessful status code of %s' % resp['status']).
This will cause successful response falls into the exception because resp['status']='200'