Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot open /artists/1, /venues/1 and /shows/1 as written in Instruction #101

Closed
im-denny opened this issue Dec 6, 2020 · 2 comments
Closed

Comments

@im-denny
Copy link

im-denny commented Dec 6, 2020

This is written in project instruction

Check out the sample pages provided at /artists/1, /venues/1, and /shows/1 for examples of the data we want to model

I installed and ran the fresh project in local, neither of these is working, its throwing error as below:

AttributeError: 'NoneType' object has no attribute 'days'

@robinlamb
Copy link
Contributor

robinlamb commented Feb 21, 2021

There is no "shows/1" as there are not individual endpoints for shows in the project. There also is no "artists/1" as the id's of the given artists are 4-6. So this is a type error in the ReadMe that someone should fix. As for the "NoneType" error that you get when you visit the Shows page, that is caused by "locale='en'" missing in the format_datetime method in py. It should read "return babel.dates.format_datetime(date, format, locale='en')". I fixed that error, along with some other things, in my pull request request: #117

@SudKul
Copy link
Contributor

SudKul commented Mar 16, 2021

#117 has now been merged.
The issue has been fixed.

@SudKul SudKul closed this as completed Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants