Fyyur Project: Add missing fields, fix broken pages, fix method that throws error, add edit buttons #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix broken form. Change text on button to Artist, not venue. Correct facebook_link label.
Add missing fields and fix the broken ones.
Add missing fields and fix the broken ones.
Add missing button connected to the artist/<artist.id>/edit endpoint. "Todo" instructions say to complete this endpoint, although the front end parts that are supposed to be complete do not use it.
Added missing edit button to connect to the /venues/<venue.id>/edit endpoint. The instructions say to complete this, but it is not used by the completed front end. This will make it much easier for users to test the endpoint when they complete it.
Added missing "locale='en'" that causes a crash.
This was referenced Feb 21, 2021
Closed
|
Hi @robinlamb |
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty frustrating first project for the program, because there is so much that is missing or not working in the completed parts of the project. Two of the fields in the pages for creating/editing artists and venues contain an incorrect id that causes these pages to display incorrectly.
These pages are also missing four fields for the following data: image link, website link, seeking talent/venue, and seeking description. It looks in the mentor help sections that some students are fixing this problems by sending in dummy values for this data when the rest of the data is taken from the form, but all of the data should be able to be submitted on the forms. A mentor helped me to add the new fields to the forms when I asked how to do this for my project, and I thought that I would share this fix that I made for my project.
Also, while there are "TODO" instructions in the project for completing the edit endpoints and there are edit pages included in the project, they are never accessed or used anywhere, which is also very confusing. One mentor said in the Mentor Help section that students were not required to do the edit endpoints, but it is still confusing because they are in the TODO section. They should either be removed from the project, or there should be a way to complete them. I added an "Edit" button on the show_artist and show_venue pages to access the endpoints in my project so they can be completed.
I also fixed the missing "locale='en" in the included format_datetime method in app.py that causes an error. I decided to open a pull request with my fixes to these issues in the already completed sections to hopefully make this project less frustrating for others.