Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README doesn't reference required Visual Studio Build Tools for Windows #34

Closed
daniel-fudge opened this issue Sep 2, 2019 · 2 comments

Comments

@daniel-fudge
Copy link
Contributor

The OpenAI Gym installation instructions are missing reference to the "Build Tools for Visual Studio 2019" from the following site.

https://visualstudio.microsoft.com/downloads/

I also found this by reading the following article.
https://towardsdatascience.com/how-to-install-openai-gym-in-a-windows-environment-338969e24d30

Even though this is an issue in the OpenAI gym, a note in this README would be very helpful.

openai/gym#11

@daniel-fudge
Copy link
Contributor Author

I made proposed changes to the README.md in the attached zip file.
README.zip

Note the README doesn't indicate how to make contributions. Making a branch doesn't work as described in issue #35

daniel-fudge added a commit to daniel-fudge/deep-reinforcement-learning that referenced this issue Sep 2, 2019
Add reference to "Build Tools for Visual Studio 2019".

Addresses issue #udacity#34.
@daniel-fudge
Copy link
Contributor Author

I also made pull request #36 from a fork to address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants