New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with Lesson 3.11 figures test #5

Closed

aviaryan opened this issue Nov 7, 2017 · 0 comments

aviaryan commented Nov 7, 2017

The test file is as follows.
http://udacity.github.io/fend/fend-refresh/lesson2/problem-set/figures/tests.json

I am concerned about this part.

 {
      "description": "The image has a relative src",
      "definition": {
        "nodes": "img",
        "attribute": "src",
        "hasSubstring": "^redwoods_state_park.jpg$"
      }
    },

The above regex won't take into account the path which is specified as "./redwoods_state_park.jpg". It is a valid relative src, right?

Related forum post: https://discussions.udacity.com/t/lesson-3-11-cant-figure-out-how-to-get-relative-src-to-work/420569/18?u=aviaryan

hbkwong closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment