This repository has been archived by the owner on Jun 28, 2022. It is now read-only.
Rmv invoking parens on callback #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In two places you wrap an anonymous function in `$()`, for the stated purpose of ensuring that the code in the function waits until browser ready before executing, however you invoke the anonymous function with parentheses. This means that the code in the function will immediately execute, and the return value of the function will be given to `$()`. Since the return value is not a function, this contradicts the correct usage of the jQuery method, and contradicts the stated purpose of using $().
|
Pull requests includes syntax errors (non-matching parens). The way it's currently done has no negative impact on how the application runs, going to leave this as is. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In two places you wrap an anonymous function in
$(), for the statedpurpose of ensuring that the code in the function waits until browser
ready before executing, however you invoke the anonymous function with
parentheses.
This means that the code in the function will immediately execute, and
the return value of the function will be given to
$(). Since thereturn value is not a function, this contradicts the correct usage of
the jQuery method, and contradicts the stated purpose of using $().