Change CSS to avoid Jasmine bug #9
Conversation
I use pictures to show how this bug makes the project more confusing to students here: http://discussions.udacity.com/t/found-an-actual-bug-in-jasmine/17025 I reported and fixed the Jasmine bug here: jasmine/jasmine#844
|
@prather-mcs Can you resolve the current conflicts? If so, I'll gladly merge this. |
I use pictures to show how this bug makes the project more confusing to students here: http://discussions.udacity.com/t/found-an-actual-bug-in-jasmine/17025 I reported and fixed the Jasmine bug here: jasmine/jasmine#844
|
Hello @walesmd. Did I resolve current conflicts? And keep the CSS changes I intended? If so, all thanks is to your Git & GitHub courseware, which I used alongside the normal Git documentation to get the PR up-to-date and ready to merge. |
| @@ -26,7 +26,7 @@ | |||
| <h1 class="header-title">Feeds</h1> | |||
| </div> | |||
|
|
|||
| <div class="menu"> | |||
| <div class="slide-menu hidden"> | |||
There was a problem hiding this comment.
Can you remove the hidden class from this element? That class does not exist in the CSS file and was removed in prior commits.
Removed 'hidden' class from class attribute value.
|
My apologies for not quite merging it in the right way for this project. I was so focused on taking the right steps with git remotes, branches, and forks, that I failed to actually get the text content right at the merge conflict line. With my latest change, that mistake should have been amended. |
Change CSS to avoid Jasmine bug
I use pictures to show how this bug makes the project more confusing
to students here:
http://discussions.udacity.com/t/found-an-actual-bug-in-jasmine/17025
I reported and fixed the Jasmine bug here:
jasmine/jasmine#844