Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media embed url fix #1165

Merged
merged 2 commits into from Oct 21, 2021
Merged

Media embed url fix #1165

merged 2 commits into from Oct 21, 2021

Conversation

dylans
Copy link
Collaborator

@dylans dylans commented Oct 21, 2021

Description

Improve the reliability of url parsing with the media-embed plugin

Issue

Fixes: Make sure there's a trailing ? before adding query parameters (was failing for YouTube)

Checklist

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn lint --fix.)
  • The relevant examples still work: (Run examples with yarn docs.)

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2021

🦋 Changeset detected

Latest commit: 3235d8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@udecode/plate-media-embed Patch
@udecode/plate-media-embed-ui Patch
@udecode/plate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/udecode/plate/2NDwD5esojN8Zod11yFTq3XZkYJh
✅ Preview: https://plate-git-fork-dylans-media-embed-url-fix-udecode.vercel.app

@zbeyens zbeyens merged commit a0b98a6 into udecode:main Oct 21, 2021
@github-actions github-actions bot mentioned this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants