Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add touch event to resizable #2425

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Conversation

Nmarinsiruela
Copy link
Collaborator

The objective of this PR is to add touch-events to Resizable, in order to make it work again as it did previous to the v20 update.

See changesets.

This PR does add the touch-related events, similar to the already existent mouse ones, in order to enable mobile support of the Resizable component.

In order to make Resizable work on mobile view, we need to add the touch event alongside the mouse
events.
@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

🦋 Changeset detected

Latest commit: f347d8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@udecode/resizable Minor
@udecode/plate-headless Patch
@udecode/plate-media Patch
@udecode/plate-table Patch
@udecode/plate Patch
@udecode/plate-ui Patch
@udecode/plate-serializer-docx Patch
@udecode/plate-ui-media Patch
@udecode/plate-serializer-csv Patch
@udecode/plate-ui-table Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 6, 2023

AI-Generated Summary: This pull request includes two patches:

  1. feat: add touch events to Resizable, add resizable to aliases-plate: This patch adds support for touch events in the Resizable component to make it work on mobile views, alongside the existing mouse events. It also adds a missing 'resizable' alias in 'aliases-plate' for improved local development.

  2. chore: add changeset: This patch adds a changeset detailing the minor version bump for the @udecode/resizable package due to the addition of touch events.

@reviewpad
Copy link
Contributor

reviewpad bot commented Jun 6, 2023

Thank you @Nmarinsiruela for this first contribution!

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jun 6, 2023
@vercel
Copy link

vercel bot commented Jun 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 0:15am
plate-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2023 0:15am

@zbeyens zbeyens enabled auto-merge (squash) June 6, 2023 12:00
@ghost
Copy link

ghost commented Jun 6, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@vercel vercel bot temporarily deployed to Preview – plate-examples June 6, 2023 12:14 Inactive
@vercel vercel bot temporarily deployed to Preview – plate June 6, 2023 12:15 Inactive
@zbeyens zbeyens merged commit 766966b into main Jun 6, 2023
11 checks passed
@zbeyens zbeyens deleted the feat/add-touch-event-to-resizable branch June 6, 2023 12:27
@zbeyens zbeyens mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants