Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TablePlugin] Table cells merging #2733

Merged
merged 18 commits into from Nov 23, 2023
Merged

[TablePlugin] Table cells merging #2733

merged 18 commits into from Nov 23, 2023

Conversation

dimaanj
Copy link
Collaborator

@dimaanj dimaanj commented Nov 8, 2023

Description

See changesets.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2023 •
edited

🦋 Changeset detected

Latest commit: 61157c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@udecode/plate-serializer-html Major
@udecode/plate-table Major
@udecode/plate Major
@udecode/plate-serializer-csv Major
@udecode/plate-serializer-docx Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 8, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 23, 2023 1:20pm

@reviewpad reviewpad bot added the medium Pull request is medium label Nov 8, 2023
@dimaanj
Merge branch 'main' of https://github.com/udecode/plate into table-ce…
dd7925b 
…lls-merging-poc-3

# Conflicts:
#	packages/table/src/components/TableElement/useTableElement.ts
@reviewpad reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Nov 10, 2023
zbeyens
zbeyens requested changes Nov 16, 2023
View reviewed changes
apps/www/src/registry/default/plate-ui/table-element.tsx Outdated Show resolved Hide resolved
packages/table/src/components/TableElement/useTableElement.ts Outdated Show resolved Hide resolved
packages/table/src/merge/deleteColumn.ts Outdated Show resolved Hide resolved
packages/table/src/merge/getIndices.ts Outdated Show resolved Hide resolved
packages/table/src/merge/getIndicesWithSpans.ts Outdated Show resolved Hide resolved
packages/table/src/merge/deleteRow.ts Outdated Show resolved Hide resolved
packages/table/src/merge/getTableGridByRange.ts Outdated Show resolved Hide resolved
packages/table/src/merge/insertTableColumn.ts Outdated Show resolved Hide resolved
packages/table/src/merge/insertTableRow.ts Outdated Show resolved Hide resolved
packages/table/src/withMergedCells.ts Outdated Show resolved Hide resolved
zbeyens
zbeyens previously requested changes Nov 16, 2023
View reviewed changes
packages/table/src/merge/insertTableColumn.ts Outdated Show resolved Hide resolved
packages/table/src/merge/deleteRow.ts Outdated Show resolved Hide resolved
packages/table/src/merge/insertTableRow.ts Outdated Show resolved Hide resolved
@dimaanj dimaanj requested a review from zbeyens November 20, 2023 14:54
@zbeyens zbeyens marked this pull request as ready for review November 23, 2023 13:16
@zbeyens zbeyens merged commit 5cc5908 into udecode:main Nov 23, 2023
7 checks passed
@zbeyens zbeyens mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbeyens zbeyens Awaiting requested review from zbeyens

Assignees
No one assigned
Labels
large Pull request is large
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dimaanj @zbeyens