Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not exclude class name #2849

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Conversation

gulfaraz
Copy link
Contributor

@gulfaraz gulfaraz commented Jan 2, 2024

Problem

In mode-dropdown-menu, DropdownMenuContent's className is being ignored.

Solution

This PR changes dropdown-menu such that DropdownMenuContent's className is not ignored.

The fix is to remove className from L60, so className is included in props.

>(({ className, ...props }, ref) => (

Copy link

changeset-bot bot commented Jan 2, 2024

⚠️ No Changeset found

Latest commit: 03798c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 11:44pm

@zbeyens
Copy link
Member

zbeyens commented Jan 2, 2024

Thanks for the PR! Could you add this in changelog.mdx?

@zbeyens zbeyens merged commit 20fd326 into udecode:main Jan 2, 2024
4 of 5 checks passed
@gulfaraz gulfaraz deleted the fix.class-name branch January 3, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants