Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table store issues #2867

Merged
merged 2 commits into from Jan 8, 2024
Merged

Fix table store issues #2867

merged 2 commits into from Jan 8, 2024

Conversation

12joan
Copy link
Collaborator

@12joan 12joan commented Jan 8, 2024

Description

See changesets.

Fixes #2866
Fixes #2831

@12joan 12joan requested a review from zbeyens January 8, 2024 15:51
Copy link

changeset-bot bot commented Jan 8, 2024

🦋 Changeset detected

Latest commit: 17e91c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 50 packages
Name Type
@udecode/plate-core Major
@udecode/plate-table Major
@udecode/plate-common Major
@udecode/plate-utils Major
@udecode/plate Major
@udecode/plate-serializer-csv Major
@udecode/plate-serializer-docx Major
@udecode/plate-alignment Major
@udecode/plate-autoformat Major
@udecode/plate-basic-elements Major
@udecode/plate-basic-marks Major
@udecode/plate-block-quote Major
@udecode/plate-break Major
@udecode/plate-caption Major
@udecode/plate-cloud Major
@udecode/plate-code-block Major
@udecode/plate-combobox Major
@udecode/plate-comments Major
@udecode/plate-cursor Major
@udecode/plate-dnd Major
@udecode/plate-emoji Major
@udecode/plate-excalidraw Major
@udecode/plate-find-replace Major
@udecode/plate-floating Major
@udecode/plate-font Major
@udecode/plate-heading Major
@udecode/plate-highlight Major
@udecode/plate-horizontal-rule Major
@udecode/plate-indent-list Major
@udecode/plate-indent Major
@udecode/plate-juice Major
@udecode/plate-kbd Major
@udecode/plate-line-height Major
@udecode/plate-link Major
@udecode/plate-list Major
@udecode/plate-media Major
@udecode/plate-mention Major
@udecode/plate-node-id Major
@udecode/plate-normalizers Major
@udecode/plate-paragraph Major
@udecode/plate-reset-node Major
@udecode/plate-resizable Major
@udecode/plate-select Major
@udecode/plate-selection Major
@udecode/plate-serializer-html Major
@udecode/plate-serializer-md Major
@udecode/plate-suggestion Major
@udecode/plate-tabbable Major
@udecode/plate-trailing-block Major
@udecode/plate-yjs Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jan 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2024 3:56pm

@@ -37,15 +37,14 @@ const useOverrideSizeFactory = (
[setOverrides]
);

// jotai supports setting with functions, but createAtomStore doesn't know that
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was true in earlier versions of jotai-x, but is now only true if atom is used explicitly when setting the initial state, and this is accurately reflected in the types.

@zbeyens zbeyens merged commit 8050148 into main Jan 8, 2024
7 checks passed
@zbeyens zbeyens deleted the fix/table-provider branch January 8, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants