Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Se llenan las tablas de solicitud y requisitos que hacían falta #16

Merged
merged 5 commits into from
Aug 26, 2021

Conversation

diagutierrezro
Copy link
Contributor

Copy link
Contributor

@AlexFBP AlexFBP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Para la mayoría de los comentarios, usar las siguientes referencias:

Adicional a lo comentado, en uno de los commit se agregó un binario (tesorería_mid.exe~), por lo que es necesario un git rebase -i develop para quitar el binario de la rama y commit (de la historia). Contactame y te ayudo a quitarlo

controllers/solicitud_avance.go Outdated Show resolved Hide resolved
conf/app.conf Outdated Show resolved Hide resolved
controllers/solicitud_avance.go Outdated Show resolved Hide resolved
helpers/apicon.go Outdated Show resolved Hide resolved
helpers/apicon.go Outdated Show resolved Hide resolved
helpers/solicitud_avance.go Outdated Show resolved Hide resolved
helpers/solicitud_avance.go Outdated Show resolved Hide resolved
helpers/solicitud_avance.go Outdated Show resolved Hide resolved
helpers/solicitud_avance.go Outdated Show resolved Hide resolved
helpers/apicon.go Outdated Show resolved Hide resolved
helpers/apicon.go Show resolved Hide resolved
helpers/apicon.go Show resolved Hide resolved
helpers/apicon.go Outdated Show resolved Hide resolved
helpers/solicitud_avance.go Outdated Show resolved Hide resolved
helpers/solicitud_avance.go Outdated Show resolved Hide resolved
helpers/solicitud_avance.go Outdated Show resolved Hide resolved
helpers/solicitud_avance.go Outdated Show resolved Hide resolved
helpers/solicitud_avance.go Outdated Show resolved Hide resolved
helpers/solicitud_avance.go Outdated Show resolved Hide resolved
helpers/solicitud_avance.go Outdated Show resolved Hide resolved
@AlexFBP AlexFBP removed their request for review August 23, 2021 22:36
}
}

// Cast result data from api to struct element
func ResultToStruct(resultado map[string]interface{}, element interface{}) (err map[string]interface{}) {
defer ErrorControlFunction("ResultToStruct", "502")
defer ErrorControlFunction("ResultToStruct", "500")
if data, ok := resultado["Data"]; ok && data != nil {
if err := MapToStruct(data, element); err == nil && element != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solo para no tener "tanto" código duplicado, el comportamiento actual equivale a quitar lo que está marcado en azul en la siguiente imagen:

image

Se puede aplicar de manera similar donde aplique

@AlexFBP AlexFBP merged commit 6e6f586 into develop Aug 26, 2021
KRONOS automation moved this from Sprint Planning (To Do) to Sprint (Done) Aug 26, 2021
@AlexFBP AlexFBP deleted the feature/llenado_tablas branch August 26, 2021 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
KRONOS
  
Sprint (Done)
Development

Successfully merging this pull request may close these issues.

None yet

2 participants