Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds latest IAM updates from AWS #631

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Adds latest IAM updates from AWS #631

merged 1 commit into from
Apr 18, 2024

Conversation

udondan
Copy link
Owner

@udondan udondan commented Apr 18, 2024

Adds latest IAM updates from AWS

Copy link

coderabbitai bot commented Apr 18, 2024

Walkthrough

Version 0.628.0 introduces enhancements across multiple AWS services, including EMR containers, internet monitoring, and outposts management. The update adds new actions and resource types, elevating the total count of supported actions to 16,552 and resource types to 1,775. Key additions include methods for managing security configurations in EMR on EKS, handling internet events, and managing capacity tasks in outposts. This release also updates documentation to reflect these changes.

Changes

Files Change Summary
CHANGELOG/v0.628.0.md, README.md, VERSION, docs/source/conf.py, docs/source/index.rst Updated version numbers and documentation to reflect the increase in supported actions and resource types.
lib/generated/.../cloudwatchinternetmonitor.ts, stats/actions/internetmonitor, stats/resources/internetmonitor Added functionalities for internet event monitoring, including methods to get and list internet events, and a new InternetEvent resource type.
lib/generated/.../emroneksemrcontainers.ts, stats/actions/emr-containers, stats/resources/emr-containers Enhanced EMR on EKS by adding methods for security configurations and introducing a new securityConfiguration resource type.
lib/generated/.../outposts.ts, stats/actions/outposts Expanded outpost management capabilities with new methods for handling capacity tasks and updated action permissions.
lib/generated/.../kinesisanalyticsv2.ts Updated the KinesisanalyticsV2 class to reference new documentation URLs for managing applications.

Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 9d3811f and 34ad8f8.
Files selected for processing (14)
  • CHANGELOG/v0.628.0.md (1 hunks)
  • README.md (1 hunks)
  • VERSION (1 hunks)
  • docs/source/conf.py (1 hunks)
  • docs/source/index.rst (1 hunks)
  • lib/generated/policy-statements/cloudwatchinternetmonitor.ts (5 hunks)
  • lib/generated/policy-statements/emroneksemrcontainers.ts (9 hunks)
  • lib/generated/policy-statements/kinesisanalyticsv2.ts (31 hunks)
  • lib/generated/policy-statements/outposts.ts (6 hunks)
  • stats/actions/emr-containers (1 hunks)
  • stats/actions/internetmonitor (1 hunks)
  • stats/actions/outposts (1 hunks)
  • stats/resources/emr-containers (1 hunks)
  • stats/resources/internetmonitor (1 hunks)
Files skipped from review due to trivial changes (2)
  • VERSION
  • docs/source/conf.py
Additional Context Used
LanguageTool (44)
CHANGELOG/v0.628.0.md (22)

Near line 1: Er is een mogelijke spelfout gevonden.
Context: New actions: - emr-containers:CreateSecurityConf...


Near line 3: Er is een mogelijke spelfout gevonden.
Context: New actions: - emr-containers:CreateSecurityConfiguration - emr-conta...


Near line 3: Er is een mogelijke spelfout gevonden.
Context: New actions: - emr-containers:CreateSecurityConfiguration - emr-containers:DescribeSecurityConfig...


Near line 4: Er is een mogelijke spelfout gevonden.
Context: ...ontainers:CreateSecurityConfiguration - emr-containers:DescribeSecurityConfiguration - emr-con...


Near line 4: Er is een mogelijke spelfout gevonden.
Context: ...eSecurityConfiguration - emr-containers:DescribeSecurityConfiguration - emr-containers:ListSecurityConfigurat...


Near line 5: Er is een mogelijke spelfout gevonden.
Context: ...tainers:DescribeSecurityConfiguration - emr-containers:ListSecurityConfigurations - internetmo...


Near line 5: Er is een mogelijke spelfout gevonden.
Context: ...eSecurityConfiguration - emr-containers:ListSecurityConfigurations - internetmonitor:GetInternetEvent - in...


Near line 6: Er is een mogelijke spelfout gevonden.
Context: ...ecurityConfigurations - internetmonitor:GetInternetEvent - internetmonitor:ListInternetEvents - ...


Near line 7: Er is een mogelijke spelfout gevonden.
Context: ...itor:GetInternetEvent - internetmonitor:ListInternetEvents - outposts:CancelCapacityTask - outpost...


Near line 8: Er is een mogelijke spelfout gevonden.
Context: ... - internetmonitor:ListInternetEvents - outposts:CancelCapacityTask - outposts:GetCapaci...


Near line 8: Er is een mogelijke spelfout gevonden.
Context: ...etmonitor:ListInternetEvents - outposts:CancelCapacityTask - outposts:GetCapacityTask - outposts:G...


Near line 9: Er is een mogelijke spelfout gevonden.
Context: ...tEvents - outposts:CancelCapacityTask - outposts:GetCapacityTask - outposts:GetOutpostSu...


Near line 9: Er is een mogelijke spelfout gevonden.
Context: ... outposts:CancelCapacityTask - outposts:GetCapacityTask - outposts:GetOutpostSupportedInstanceT...


Near line 10: Er is een mogelijke spelfout gevonden.
Context: ...pacityTask - outposts:GetCapacityTask - outposts:GetOutpostSupportedInstanceTypes - outp...


Near line 10: Er is een mogelijke spelfout gevonden.
Context: ...k - outposts:GetCapacityTask - outposts:GetOutpostSupportedInstanceTypes - outposts:ListCapacityTasks - outposts...


Near line 11: Er is een mogelijke spelfout gevonden.
Context: ...osts:GetOutpostSupportedInstanceTypes - outposts:ListCapacityTasks - outposts:StartCapac...


Near line 11: Er is een mogelijke spelfout gevonden.
Context: ...utpostSupportedInstanceTypes - outposts:ListCapacityTasks - outposts:StartCapacityTask **New res...


Near line 12: Er is een mogelijke spelfout gevonden.
Context: ...nceTypes - outposts:ListCapacityTasks - outposts:StartCapacityTask **New resource types...


Near line 12: Er is een mogelijke spelfout gevonden.
Context: ...- outposts:ListCapacityTasks - outposts:StartCapacityTask New resource types: - emr-contain...


Near line 16: Er is een mogelijke spelfout gevonden.
Context: ...apacityTask New resource types: - emr-containers:securityConfiguration - internetmonitor...


Near line 16: Er is een mogelijke spelfout gevonden.
Context: ...New resource types:** - emr-containers:securityConfiguration - internetmonitor:InternetEvent


Near line 17: Er is een mogelijke spelfout gevonden.
Context: ...securityConfiguration - internetmonitor:InternetEvent

README.md (22)

Near line 3: Possible spelling mistake found.
Context: ...o=github&label=GitHub%20Stars)][source] [![iam-floyd](https://img.shields.io/github/v/releas...


Near line 25: A comma may be missing after the conjunctive/linking adverb ‘Therefore’.
Context: ... change while I implement new features. Therefore make sure you use an exact version in y...


Near line 25: Possible spelling mistake found.
Context: ...e sure you use an exact version in your package.json before it reaches 1.0.0.** ## Documen...


Near line 37: Possible spelling mistake found.
Context: ...ferent package variants available: - iam-floyd: Can be used in AWS SDK or for whatev...


Near line 38: Possible spelling mistake found.
Context: ...://www.npmjs.com/package/iam-floyd) - cdk-iam-floyd: Integrates into [AWS CDK] and extend...


Near line 47: Possible typo: you repeated a whitespace
Context: ...io]. ## CDK Compatibility Matrix | CDK | cdk-iam-floyd | | -------...


Near line 47: Possible spelling mistake found.
Context: ...DK Compatibility Matrix | CDK | cdk-iam-floyd | | ---------- | ---------...


Near line 47: Possible typo: you repeated a whitespace
Context: ...ity Matrix | CDK | cdk-iam-floyd | | ---------- | -----------------------...


Near line 49: Do you wish to insert an arrow?
Context: ...------ | -------------------------- | | <= 1.151.0 | <= 0.285.0 | ...


Near line 49: Do you wish to insert an arrow?
Context: ...---------------------- | | <= 1.151.0 | <= 0.285.0 | | >= 1.152.0 ...


Near line 49: Possible typo: you repeated a whitespace
Context: ...------------ | | <= 1.151.0 | <= 0.285.0 | | >= 1.152.0 | 0.286.0 ...


Near line 50: Possible typo: you repeated a whitespace
Context: ... | | >= 1.152.0 | 0.286.0 | | >= 1.158.0 | **No compatible version...


Near line 52: Possible typo: you repeated a whitespace
Context: ... No compatible version! | | >= 2.0.0 | >= 0.300.0 | | >= 2.20...


Near line 52: Possible typo: you repeated a whitespace
Context: ...e version!** | | >= 2.0.0 | >= 0.300.0 | | >= 2.20.0 | >= 0.351.0 ...


Near line 53: Possible typo: you repeated a whitespace
Context: ...>= 0.300.0 | | >= 2.20.0 | >= 0.351.0 | | >= 2.26...


Near line 53: Possible typo: you repeated a whitespace
Context: ... | | >= 2.20.0 | >= 0.351.0 | | >= 2.26.0 | >= 0.377.0 ...


Near line 54: Possible typo: you repeated a whitespace
Context: ...>= 0.351.0 | | >= 2.26.0 | >= 0.377.0 | | 2.29.x ...


Near line 54: Possible typo: you repeated a whitespace
Context: ... | | >= 2.26.0 | >= 0.377.0 | | 2.29.x | **No compatible version...


Near line 55: Possible typo: you repeated a whitespace
Context: ... | >= 0.377.0 | | 2.29.x | No compatible version! | | >= 2.30...


Near line 56: Possible typo: you repeated a whitespace
Context: ...No compatible version! | | >= 2.30.0 | >= 0.391.0 | --- ## ...


Near line 56: Possible typo: you repeated a whitespace
Context: ...e version!** | | >= 2.30.0 | >= 0.391.0 | --- ## Legal The code contained in ...


Near line 64: Possible missing comma found.
Context: ...eir services are trademarks, registered trademarks or trade dress of AWS in the U.S. and/o...

Additional comments not posted (38)
stats/resources/internetmonitor (1)

2-2: The addition of internetmonitor:InternetEvent aligns with the PR objectives to enhance IAM functionalities for internet monitoring. Looks good!

stats/resources/emr-containers (1)

4-4: The addition of emr-containers:securityConfiguration is consistent with the PR's aim to manage security configurations in EMR containers. Well done!

CHANGELOG/v0.628.0.md (1)

1-17: The changelog entries accurately reflect the new actions and resource types introduced in this version update. Nicely documented!

stats/actions/internetmonitor (1)

4-10: The addition of actions GetInternetEvent and ListInternetEvents enhances the internet monitoring capabilities as described in the PR. Good job!

stats/actions/emr-containers (1)

4-18: The new actions CreateSecurityConfiguration, DescribeSecurityConfiguration, and ListSecurityConfigurations are correctly added to enhance security management in EMR containers. Well implemented!

stats/actions/outposts (1)

1-26: The new actions and modifications to existing actions for the outposts module are correctly implemented. This update aligns well with the described enhancements in the PR.

docs/source/index.rst (1)

34-35: The documentation updates accurately reflect the new numbers of supported actions and resource types. This ensures that the documentation remains current with the latest changes.

README.md (1)

20-21: The README updates accurately reflect the new numbers of supported actions and resource types. This ensures that users are informed about the latest capabilities of the tool.

lib/generated/policy-statements/cloudwatchinternetmonitor.ts (3)

58-67: Method toGetInternetEvent correctly implements the functionality to get internet event information.


124-133: Method toListInternetEvents correctly implements the functionality to list all internet events.


279-290: Method onInternetEvent correctly implements the functionality to add a resource of type InternetEvent to the statement.

lib/generated/policy-statements/outposts.ts (6)

21-30: Method toCancelCapacityTask correctly implements the functionality to cancel a Capacity Task.


117-126: Method toGetCapacityTask correctly implements the functionality to get information about the specified Capacity Task.


183-192: Method toGetOutpostSupportedInstanceTypes correctly implements the functionality to get the supported instance types for the specified Outpost.


238-247: Method toListCapacityTasks correctly implements the functionality to list the Capacity Tasks for your AWS account.


304-313: Method toStartCapacityTask correctly implements the functionality to create a Capacity Task.


401-431: Updates to accessLevelList correctly categorize new methods related to Capacity Tasks under appropriate access levels.

lib/generated/policy-statements/kinesisanalyticsv2.ts (14)

26-26: Method toAddApplicationCloudWatchLoggingOption correctly updates the documentation URL to the "managed-flink" documentation.


37-37: Method toAddApplicationInput correctly updates the documentation URL to the "managed-flink" documentation.


48-48: Method toAddApplicationInputProcessingConfiguration correctly updates the documentation URL to the "managed-flink" documentation.


59-59: Method toAddApplicationOutput correctly updates the documentation URL to the "managed-flink" documentation.


70-70: Method toAddApplicationReferenceDataSource correctly updates the documentation URL to the "managed-flink" documentation.


81-81: Method toAddApplicationVpcConfiguration correctly updates the documentation URL to the "managed-flink" documentation.


99-99: Method toCreateApplication correctly updates the documentation URL to the "managed-flink" documentation.


110-110: Method toCreateApplicationPresignedUrl correctly updates the documentation URL to the "managed-flink" documentation.


121-121: Method toCreateApplicationSnapshot correctly updates the documentation URL to the "managed-flink" documentation.


132-132: Method toDeleteApplication correctly updates the documentation URL to the "managed-flink" documentation.


143-143: Method toDeleteApplicationCloudWatchLoggingOption correctly updates the documentation URL to the "managed-flink" documentation.


154-154: Method toDeleteApplicationInputProcessingConfiguration correctly updates the documentation URL to the "managed-flink" documentation.


165-165: Method toDeleteApplicationOutput correctly updates the documentation URL to the "managed-flink" documentation.


176-176: Method toDeleteApplicationReferenceDataSource correctly updates the documentation URL to the "managed-flink" documentation.

lib/generated/policy-statements/emroneksemrcontainers.ts (7)

63-76: Addition of toCreateSecurityConfiguration method.

This method correctly sets up the IAM policy statement for creating a security configuration with appropriate access level and conditions. The documentation link is correctly provided, ensuring easy reference to the official AWS API documentation.


159-168: Addition of toDescribeSecurityConfiguration method.

This method is well-implemented for describing a security configuration. It correctly assigns the 'Read' access level and includes the relevant AWS documentation URL, which is beneficial for developers looking for more detailed information.


225-234: Addition of toListSecurityConfigurations method.

The method for listing security configurations is correctly implemented with the 'List' access level. The inclusion of the AWS documentation URL is a good practice, providing a direct link to the relevant API reference.


318-331: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [309-328]

Update to accessLevelList to include new security configuration methods.

The accessLevelList has been correctly updated to include the new methods (CreateSecurityConfiguration, DescribeSecurityConfiguration, ListSecurityConfigurations) under their respective access levels. This ensures that the permissions are correctly categorized.


408-423: Addition of onSecurityConfiguration resource type method.

The method for adding a resource of type securityConfiguration is correctly implemented. It includes the potential conditions for access filtering and provides a comprehensive ARN structure for the resource, aligning with AWS best practices.


430-436: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [433-456]

Update to ifAwsRequestTag and ifAwsResourceTag to include securityConfiguration.

The condition filters ifAwsRequestTag and ifAwsResourceTag have been appropriately updated to include the securityConfiguration type. This update is crucial for maintaining proper access control and tagging capabilities.


471-477: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [474-494]

Update to ifAwsTagKeys to include new methods related to securityConfiguration.

The ifAwsTagKeys condition filter has been updated to include the new security configuration-related methods. This ensures that the tag keys present in the request are correctly evaluated for these actions, aligning with IAM best practices.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@udondan udondan merged commit efbfa78 into main Apr 18, 2024
8 checks passed
@udondan udondan deleted the iam-updates branch April 18, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant