Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way that
to_path
andto_logical_path
reacts to empty paths wasn't properly specified nor implemented. The current behavior ends up being rather on, in that the main separator is added so that the following would produce an absolute path on Linux:This is clearly dysfunctional and contrary to what this crate is trying to accomplish. So this patch changes this behavior so that we only add the main separator for cases where the
from
path is non-empty.What we then get instead is: