Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on DynamicFormService.detectChanges() #1060

Closed
mischkl opened this issue Feb 26, 2020 · 5 comments
Closed

Error on DynamicFormService.detectChanges() #1060

mischkl opened this issue Feb 26, 2020 · 5 comments

Comments

@mischkl
Copy link
Contributor

mischkl commented Feb 26, 2020

I'm submitting a


[X] Bug / Regression
[ ] Feature Request / Proposal

I'm using


NG Dynamic Forms Version: `10.1.0`

[ ] Basic UI
[ ] Bootstrap UI  
[ ] Foundation UI
[ ] Ionic UI
[ ] Kendo UI
[X] Material  
[ ] NG Bootstrap
[ ] Prime NG

Description

The following error occurs in some cases when calling DynamicFormService.detectChanges() on a form component:

TypeError: Cannot read property 'instance' of undefined
	    at DynamicMaterialFormControlContainerComponent.markForCheck 
	    at QueryList.forEach 
	    at DynamicMaterialFormComponent.markForCheck 
	    at DynamicFormService.detectChanges 
@mischkl
Copy link
Contributor Author

mischkl commented Feb 26, 2020

Fix submitted: #1061

@mischkl
Copy link
Contributor Author

mischkl commented Mar 10, 2020

@udos86 It would be great if you could merge this simple change, as it is causing us to use lots of try/catch all over the place at the moment.

@mischkl
Copy link
Contributor Author

mischkl commented Apr 29, 2020

New version, and this bug still isn't fixed despite a pull request already being submitted? What gives? @udos86

udos86 added a commit that referenced this issue Apr 30, 2020
Fix #1060 error on DynamicFormService.detectChanges()
@udos86 udos86 closed this as completed in fb9527e Apr 30, 2020
@udos86
Copy link
Owner

udos86 commented Apr 30, 2020

@mischkl

Maintaining a huge open source project over multiple years is just a lousy business when working a full-time job, teaching at university, having a family while living in effing corona times.

11.0.3 should fix it

@mischkl
Copy link
Contributor Author

mischkl commented Apr 30, 2020

@udos86 thanks for the fix, didn't mean to be harsh, was just frustrated since I kept running into the same issue repeatedly. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants