Bug s3 cdn iss481 #492
Open
Bug s3 cdn iss481 #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… makes SIW and AuthJS versions configurable via ENV
|
Related to the SonarCloud security hotspots, I could easily include hashes for the AuthJS and SIW Javascript libraries coming from the CDN, but should I? We would need to account for hashes for different versions, should someone choose to use a different version, or make the hash values part of the config directly. That might not be a bad idea; have default versions and hashes in app_config.py, and let environment variables override them. |
noinarisak
requested changes
Feb 8, 2022
noinarisak
requested changes
Feb 8, 2022
… makes SIW and AuthJS versions configurable via ENV
…bug-s3-cdn-iss481
added 2 commits
March 22, 2022 17:33
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch removes references to the Zartan S3 CDN for the Okta sign-in widget and AuthJS library and replaces them with the Okta CDN URL. Additionally, the SIW and AuthJS versions are now configurable via environment variables. The default SIW and AuthJS versions are the latest available without any breaking changes (i.e. < 6.0.0).
Resolves #481