-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gracefully handle when requesting more bins than there are unique edges results in error #20
Labels
Comments
Thank you Kuan, that is a good idea and sounds reasonable. Would you be willing to add this to your existing plot PR #22? |
Sounds good, will get to it later today! |
Resolved via latest commit, the |
Example operation:
|
kuanb
added a commit
to kuanb/urbanaccess
that referenced
this issue
Apr 27, 2017
sablanchard
pushed a commit
that referenced
this issue
May 3, 2017
* create color columns handles nan vals, prevents floats * resolves issue #20 * rename func to _recursive_category_gen
Fixed with PR #22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, if you request more bins than there are unique edges, an error will be raised. I wonder if it would be reasonable to simply pick the
min()
of the number of unique edges or the requested argument parameternum_bins
?Example:
The text was updated successfully, but these errors were encountered: