Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big refactor #124

Merged
merged 103 commits into from
Jul 31, 2019
Merged

Big refactor #124

merged 103 commits into from
Jul 31, 2019

Conversation

TonyBagnall
Copy link
Member

much of the code has been restructured. Classifiers are now in sub directories that relate to their core transformation, interfaces have been rearranged and renamed, and redundant files removed. Some classifiers have been updated, including new versions of RISE and BOSS. Feel free to comment on other changes

James Large and others added 30 commits April 2, 2019 14:50
…nalyses and wanting to transpose maybe thered be problems, but i doubt it, expecially it results cleaning turned on. tested in workingExample..., but commented out due to incompatability with the datset groupings also shown in that example
…Dists. bringing together mce updates into single branch before attempting to merge with tonys refactors
…ifier names mid-exp to avoid bloating setclassifier with specific parasetups etc
…/random-boss

# Conflicts:
#	src/main/java/experiments/ClassifierLists.java
#	src/main/java/experiments/DataSets.java
#	src/main/java/timeseriesweka/classifiers/dictionary_based/BOSS.java
MatthewMiddlehurst and others added 18 commits July 22, 2019 17:47
…/random-boss

# Conflicts:
#	src/main/java/timeseriesweka/classifiers/dictionary_based/BOSS.java
global variables removed, setClassifier now performs the switch to choose classifier, setClassifierClassic now creates an ExperimentalArguments object and calls setClassifier. This has tidied up the use case for loading classifiers from file
Small clean up and basic threading interface
…dev/random-boss

# Conflicts:
#	src/main/java/timeseriesweka/classifiers/dictionary_based/WEASEL.java
@james-large
Copy link
Member

Datasets loading/resampling refactor

Usage examples added, might add links to/generally update the readme? Or leave for a future PR along with version 1.0 or something

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be all stable, i'm happy for the current dev changes to be released.

Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little extra doesn't hurt i guess

@TonyBagnall TonyBagnall merged commit 8c8d15b into master Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants