Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix programme wall thermostat #46

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MassiPi
Copy link

@MassiPi MassiPi commented Jul 17, 2023

The original API gets the weekly program only from the radiator thermostat.
This creates problem with the HOME ASSISTANT integration since it's not possible to set automatic mode on wall thermostats.
The fix gets the weekly program also from wall thermostat.

Getting weekly program also for wall thermostat. The C message is slightly different for wall thermostat, the programme starts with byte 22, but it's lenght must be fixed to 182 since is followed by 3 unknown bytes
need to manage weekly program also for wall thermostats to fix error in home assistant integration
@betz0r
Copy link

betz0r commented Oct 18, 2023

Can we bump this up as it just fixes a bug. Any maintainer able to merge this MR?

@MassiPi
Copy link
Author

MassiPi commented Oct 18, 2023

i think this package has no mantainers left :)
i fear you'll have to end up with a custom integration to fix these bugs..
our MAX! system was discontinued in July, this is hardly going back to life

@betz0r
Copy link

betz0r commented Oct 18, 2023

MAX! Cloud service was discontinued, but the devices locally will run forever - no need to switch hardware for now.

@unaiur also abandoned this project now?

@joostlek
Copy link

If @uebelack doesn't respond, you can always fork the library and publish it to PyPi yourself

@MassiPi
Copy link
Author

MassiPi commented Oct 18, 2023

yep
#43 (comment)
i do agree there is no need to switch hardware for now, with HA and persistent connection the system still workd perfectly

@betz0r
Copy link

betz0r commented Oct 18, 2023

If @uebelack doesn't respond, you can always fork the library and publish it to PyPi yourself

afaik in another issue-thread it was clarified: @uebelack abanondend the repo and handed PyPi ownership to @unaiur - hopefully we will see some activity again ;)

@MassiPi
Copy link
Author

MassiPi commented Oct 18, 2023

hopefully we will see some activity again ;)

i still think the easiest way is creating a custom component based on the available one. I had to modify both the integration files and this class files to fix bugs (i found some) and add some useful - to me - functions (e.g. a fake HVAC for the whole home to set all thermostats to the same target with just one command)
i'm not going to publish this on pypi or trying to get the modified integration in HA, but if you are interested i can try to understand how to publish everything on git :)

@betz0r
Copy link

betz0r commented Oct 18, 2023

hopefully we will see some activity again ;)

i still think the easiest way is creating a custom component based on the available one. I had to modify both the integration files and this class files to fix bugs (i found some) and add some useful - to me - functions (e.g. a fake HVAC for the whole home to set all thermostats to the same target with just one command) i'm not going to publish this on pypi or trying to get the modified integration in HA, but if you are interested i can try to understand how to publish everything on git :)

  1. install git from https://git-scm.com/ or from your package manager (depending on your OS) like linux or macOS
  2. open a command line and navigate to your project directory
  3. git init
  4. git add . be aware that all files in the directory and subdirectories are going to be part of the project you want to publish on github. if you want to prevent files from being added to the repository i recommend to create a file named .gitignore and list all files/directories which should be excluded.
  5. git commit -m "initial commit"

Now you have a local git repository. To publish to github, we need to create a new repository on github and then add this newly created github repository as remote repository to our local repository.

  1. git remote add origin [your_remote_repository_url] i.e. git remote add origin https://github.com/MassiPi/python-maxcube-api.git
  2. git push -u origin main

Now your local project sourcecode should be available in your newly created github repository.

Further information about how to work with git as a version control system i recommend a free online course like Khan's Academy or https://www.codecademy.com/learn/learn-git

@MassiPi
Copy link
Author

MassiPi commented Oct 18, 2023

oh well i just uploaded files don't worry :)
https://github.com/MassiPi/maxcube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants