New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throwing "no case clause matching" when use with GuardianDB #242
Comments
Module Guardian line 105, changed `:ok` to `{:ok, _}` ueberauth#242
Apologies if I didn't do the pull request right, I am not familiar to the proper way of contributing to a project. |
Thanks for the report @yuchunc 👍 I'll take a peek at your PR today. |
Yep, I'm getting the same thing. Applying PR #243 fixed it locally. (Until it's merged I can't use it in my CI system, of course.) |
* fix pattern miss match when use with GuardianDB Module Guardian line 105, changed `:ok` to `{:ok, _}` #242 * fix Guardian.Hooks.Test's after_encode_and_sign output
Any idea on when you'll cut a new release for hex.pm? This will remain broken for anyone until then. |
@jamesvl I intend to cut a new release today but in the meantime you can use {:guardian, github: "ueberauth/guardian"} |
0.14.1 has been released. |
Hi, I got this error even after the upgrade. I got the same error with |
Same issue as @collegeimprovements after upgrade to 0.14.1. Found the issue and opened a pull request #250 |
@larryweya / @collegeimprovements / @NilsLattek — a fix has been merged into master, before I cut a new release could one of you please verify that master is working for you? I'm currently traveling and don't have everything I need to smoke test it. |
@doomspork I was having the same problem and using Is this the fix? |
@doomspork works for me too. |
Thank you @Ch4s3 and @larryweya 👍 |
I've released 0.14.2, hopefully this resolves everyone's issues. The ueberauth org is taking over GuardianDB maintenance so I'll be putting some time into clean-up in the coming weeks. |
I am facing the same problem and 0.14.2 works fine |
Can confirm, 0.14.2 works |
* fix pattern miss match when use with GuardianDB Module Guardian line 105, changed `:ok` to `{:ok, _}` ueberauth#242 * fix Guardian.Hooks.Test's after_encode_and_sign output
Hi, I upgraded the to the latest Guardian package, and ran in to this exception:
after some digging into the code I think it's a miss match between:
GuardianDb's [after_encode_and_sign] (https://github.com/hassox/guardian_db/blob/master/lib/guardian_db.ex#L77)
and
Guardian's https://github.com/ueberauth/guardian/blob/master/lib/guardian.ex#L105
If we just tweak the pattern a little bit to {:ok, _} it would resolve the issue.
The text was updated successfully, but these errors were encountered: