plug to ensure load_resource actually worked #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @ericsullivan, I'll review this today and leave feedback 👍 |
|
Thank you again @ericsullivan 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first used Guardian it was strange that current_resource could be nil after calling the LoadResource plug. It still seems to be an issue. I decided to go for 3 pull requests and add it.
The discussion suggested using a new plug or updating LoadResource. I used a new plug because I didn't want to change LoadResources current behavior, but it could have gone either way, maybe with the plug looking like this:
I'm not sure about the default return code or message. I also didn't know if it should call one of the existing error handler methods, but I figured leaving it explicit gives users of the plug the most flexibility. The code / specs / documentation was just copied and a few variables changed, so thanks for the great base to work in.