Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure conn halt #617

Merged
merged 3 commits into from
Oct 20, 2019

Conversation

hauptbenutzer
Copy link
Contributor

Hi!

I finally got around to putting this PR together. It addresses the discussion in #401.
The halt option is added to all relevant plugs and defaults to true, as to not break any current behaviour. Let me know what you think.

Cheers!

@codecov-io
Copy link

codecov-io commented Oct 19, 2019

Codecov Report

Merging #617 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
+ Coverage   86.22%   86.32%   +0.09%     
==========================================
  Files          21       21              
  Lines         421      424       +3     
==========================================
+ Hits          363      366       +3     
  Misses         58       58
Impacted Files Coverage Δ
lib/guardian/plug/load_resource.ex 86.66% <100%> (ø) ⬆️
lib/guardian/plug/ensure_authenticated.ex 88.88% <100%> (ø) ⬆️
lib/guardian/plug/verify_session.ex 94.44% <100%> (ø) ⬆️
lib/guardian/plug.ex 84.61% <100%> (+0.61%) ⬆️
lib/guardian/plug/verify_header.ex 70.83% <100%> (ø) ⬆️
lib/guardian/plug/verify_cookie.ex 91.3% <100%> (ø) ⬆️
lib/guardian/plug/ensure_not_authenticated.ex 80% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38a5558...e1c1b36. Read the comment docs.

@yordis
Copy link
Member

yordis commented Oct 19, 2019

@hauptbenutzer thank you very much. Would you mind adding a new entry to the CHANGELOG file following the previous examples?

@hauptbenutzer
Copy link
Contributor Author

@yordis Like this? Not really sure what an appropriate version bump would be.

@yordis yordis merged commit 57de1b2 into ueberauth:master Oct 20, 2019
@yordis
Copy link
Member

yordis commented Oct 20, 2019

@hauptbenutzer yeah that was totally fine

@mwri mwri mentioned this pull request Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants