Users should be able to change most config values at runtime #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other config variables should be read at runtime so that they can be overridden at runtime vs compile time. This allows for 12 Factor type deployment
The || with the pipe looked confusing
|
Hey, do you mind adding an entry here https://github.com/ueberauth/guardian/blob/master/CHANGELOG.md and changing the |
yordis
requested changes
Nov 24, 2022
|
@geofflane did you get to test this in your app at least? I agree it is a bit tricky to test for sure. |
Yes, I did test locally and 2.3.0 fails to start, but with this change the app will start with a changed secret_key value. |
yordis
approved these changes
Nov 24, 2022
|
💜 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permissions are used at compile time, but other config variables should be read at runtime so that they can be overridden at runtime vs compile time. This allows for 12 Factor type deployment
This is intended to fix: #706
Existing tests pass, but I'm not really sure how to write a test for this exact issue.
Application.put_envin a test doesn't trigger the error.Happy to get some help on how to test that and update this PR