Feature: Add configuration to only store one token type #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -101,6 +111,11 @@ defmodule GuardianDb do | |||
| end | |||
| end | |||
|
|
|||
| def configured_type_matches(type) do | |||
| env_token_type = Keyword.get(Application.get_env(:guardian_db, GuardianDb), :token_type) | |||
There was a problem hiding this comment.
I think if we made it so that you could configure the token type to use a list of tokens that would be sweet
|
This is a great addition @hannahhoward. The only thing I think would make it more awesome is if we were able to handle a list of token types. Thoughts? |
|
Ping @hannahhoward / @hassox — do we still want to move forward with this? If @hannahhoward isn't available I can take over the changes. |
|
If there's no objections by either @hannahhoward or @hassox, myself or @ybur-yug or I will clean this up and get it merged in. |
|
I can work on the list of types |
|
That works @imranismail 👍 |
|
Closing this in favor of #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! This is an additional feature that would allow you to only store tokens that match a certain type. My thinking is if you want to add refresh tokens to Guardian, then the ideal scenario is to set short expirations on the access tokens and not worry about storing then (therefore avoiding a DB check) but to store refresh tokens in a DB so you can revoke them if they are compromised (or a user logs out).
So you'd use GuardianDB only for tokens of type "refresh" for example.