Fix guardian 0.14 compatibility #34

Merged
merged 1 commit into from Jan 10, 2017

Projects

None yet

3 participants

@imranismail
Contributor

No description provided.

@AlexKovalevych

@imranismail is it possible to have two different PRs. One for 0.14 compatibility, another for ecto version update. E.g. i'm using mongodb, and ecto driver is not ready for 2.1 version, so that way i can still use guardian_db with 0.14 version fix and shouldn't wait till mongodb_ecto driver have 2.1 version support?

@imranismail
Contributor

@AlexKovalevych sure, I'll separate them

@imranismail imranismail changed the title from Fix guardian 0.14 compatibility and update ecto dependency to 2.1 to Fix guardian 0.14 compatibility Jan 3, 2017
@imranismail
Contributor
imranismail commented Jan 3, 2017 edited

Okay, rewrote the history, good to go. Also someone already has a PR for Ecto update, so I'm skipping that

@doomspork
Member

@imranismail the ecto update has been merged in, could you please resolve the conflicts?

@imranismail
Contributor

@doomspork resolved!

@@ -53,8 +53,14 @@ defmodule GuardianDb do
Create a new new token based on the JWT and decoded claims
"""
def create!(claims, jwt) do
- prepared_claims = claims |> Dict.put("jwt", jwt) |> Dict.put("claims", claims)
- GuardianDb.repo.insert cast(%Token{}, prepared_claims, [:jti, :typ, :aud, :iss, :sub, :exp, :jwt, :claims])
+ prepared_claims =
@doomspork
doomspork Jan 10, 2017 Member

Thank you for formatting this 💜

@doomspork doomspork merged commit 89808ea into ueberauth:master Jan 10, 2017
@doomspork
Member

Thanks again @imranismail 😀

@Moxide Moxide added a commit to Moxide/guardian_db that referenced this pull request Jan 13, 2017
@Moxide Moxide Remove part of #34 since the original issue has been fixed in guardian e5c946e
@Moxide Moxide referenced this pull request Jan 13, 2017
Closed

Should revert #34 #39

@doomspork doomspork added a commit that referenced this pull request Jan 16, 2017
@Moxide @doomspork Moxide + doomspork Remove part of #34 since the original issue has been fixed in guardian (
#40)

* Remove part of #34 since the original issue has been fixed in guardian

* code cleaning
093e48f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment