Fix guardian 0.14 compatibility #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@imranismail is it possible to have two different PRs. One for 0.14 compatibility, another for ecto version update. E.g. i'm using mongodb, and ecto driver is not ready for 2.1 version, so that way i can still use guardian_db with 0.14 version fix and shouldn't wait till mongodb_ecto driver have 2.1 version support? |
|
@AlexKovalevych sure, I'll separate them |
imranismail
changed the title
|
Okay, rewrote the history, good to go. Also someone already has a PR for Ecto update, so I'm skipping that |
|
@imranismail the ecto update has been merged in, could you please resolve the conflicts? |
|
@doomspork resolved! |
doomspork
reviewed
Jan 10, 2017
| @@ -53,8 +53,14 @@ defmodule GuardianDb do | |||
| Create a new new token based on the JWT and decoded claims | |||
| """ | |||
| def create!(claims, jwt) do | |||
| prepared_claims = claims |> Dict.put("jwt", jwt) |> Dict.put("claims", claims) | |||
| GuardianDb.repo.insert cast(%Token{}, prepared_claims, [:jti, :typ, :aud, :iss, :sub, :exp, :jwt, :claims]) | |||
| prepared_claims = | |||
There was a problem hiding this comment.
Thank you for formatting this 💜
|
Thanks again @imranismail 😀 |
fpalluel
added a commit
to fpalluel/guardian_db
that referenced
this pull request
Jan 13, 2017
Closed
doomspork
pushed a commit
that referenced
this pull request
Feb 5, 2017
* Remove part of #34 since the original issue has been fixed in guardian * code cleaning * Also accepts binary values for sweep_interval. May be useful when configuring application with environment variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.