Skip to content

Commit

Permalink
Expand travis matrix and update Makefile (#92)
Browse files Browse the repository at this point in the history
* Expand travis matrix and update Makefile

* Correct spec
  • Loading branch information
doomspork committed Mar 13, 2019
1 parent 96542d1 commit a451955
Show file tree
Hide file tree
Showing 3 changed files with 27 additions and 4 deletions.
25 changes: 23 additions & 2 deletions .travis.yml
Expand Up @@ -4,15 +4,36 @@ notifications:
email: false

elixir:
- 1.6
- 1.8
- 1.7

otp_release:
- 21.1
- 20.3
- 21.0
- 19.3
- 18.3

matrix:
exclude:
- elixir: 1.8
otp_release: 19.3
- elixir: 1.8
otp_release: 18.3

before_script:
- travis_wait mix dialyzer --plt

script:
- make testing

cache:
directories:
- _build
- deps
- priv/plts

after_script:
- make docs

after_success:
- bash <(curl -s https://codecov.io/bash)
4 changes: 3 additions & 1 deletion Makefile
Expand Up @@ -4,9 +4,11 @@ deps:
mix deps.get

testing: deps
mix credo
mix do compile --warnings-as-errors --force
mix format --check-formatted
mix credo
MIX_ENV=test mix coveralls.json
mix dialyzer --halt-exit-status

docs:
mix inch.report
2 changes: 1 addition & 1 deletion lib/ueberauth/strategies/helpers.ex
Expand Up @@ -67,7 +67,7 @@ defmodule Ueberauth.Strategy.Helpers do
This method will filter conn.params with whitelisted params from :callback_params settings
"""
@spec callback_params(Plug.Conn.t()) :: list(String.t())
@spec callback_params(Plug.Conn.t()) :: keyword()
def callback_params(conn, opts \\ []) do
callback_params = from_private(conn, :callback_params) || []

Expand Down

0 comments on commit a451955

Please sign in to comment.