Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: adding ueberauth to the applications list is no longer necessary #117

Closed
FractalWire opened this issue Apr 10, 2020 · 3 comments
Closed

Comments

@FractalWire
Copy link
Contributor

The doc mention both in the main repo and in the various strategy repos that you should add Ueberauth and its strategies to the applications list like so:

def application do
  # Add the application to your list of applications.
  # This will ensure that it will be included in a release.
  [applications: [:logger, :ueberauth]]
end

For recent version of Elixir, this is no longer necessary and will, in fact, cause an error difficult to understand.

The doc should be updated to mention this change.

https://elixirforum.com/t/error-dbconnection-when-running-mix-phx-server/22652/2
https://www.amberbit.com/blog/2017/9/22/elixir-applications-vs-extra_applications-guide/

@doomspork
Copy link
Member

Hi @FractalWire would you mind submitting a PR?

FractalWire added a commit to FractalWire/ueberauth that referenced this issue Apr 11, 2020
@FractalWire
Copy link
Contributor Author

Sure ;)
#118

@Hanspagh
Copy link
Contributor

Closed by #118

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants