Add API functions to allow dynamic providers #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
===========================================
+ Coverage 58.76% 74.28% +15.52%
===========================================
Files 4 4
Lines 97 105 +8
===========================================
+ Hits 57 78 +21
+ Misses 40 27 -13
Continue to review full report at Codecov.
|
|
@mildred would you mind adding some test cases? |
mildred
force-pushed
the
dynamic-providers
branch
from
9011cc4
to
fac64e7
Compare
|
Updated PR to add two test cases ensuring that the strategy is correctly called from those functions. |
mildred
force-pushed
the
dynamic-providers
branch
from
fac64e7
to
ed6b36c
Compare
mildred
force-pushed
the
dynamic-providers
branch
from
ed6b36c
to
fa090f4
Compare
|
@yordis / @ueberauth/developers are we good to merge? |
yordis
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should implement #90