Allow multiple configurations of a provider #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert back to behaviour of v0.2.0 where configuring a provider/strategy multiple times allows it to be used in an application at multiple different paths.
|
|
||
| providers = if provider_list == :all do | ||
| all_providers | ||
| else | ||
| Map.split(all_providers, provider_list) | ||
| Keyword.split(all_providers, provider_list) |
There was a problem hiding this comment.
While we're touching this line could you refactor it as such:
all_providers
|> Keyword.split(provider_list)
|> elem(0)
|
@hassox could you take a look at this? This is fine by me but I'm not sure if there was a reason behind your previous change. |
|
Thank you @RoryGreen, sorry for the delays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #31.