Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging in detail #70

Merged
merged 1 commit into from
May 5, 2022
Merged

Logging in detail #70

merged 1 commit into from
May 5, 2022

Conversation

msaurabhee
Copy link
Contributor

Different people are facing different issue
but we are not able to identify the issue
since the error from the client (facebook)
is not being thrown back to the user.

This change will provide correct message from
the client.

Copy link
Member

@yordis yordis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, could you add an entry in https://github.com/ueberauth/ueberauth_facebook/blob/master/CHANGELOG.md

and bumb the version in the mix.exs?

    Different people are facing different issue
    but we are not able to identify the issue
    since the error from the client (facebook)
    is not being thrown back to the user.

    This change will provide correct message from
    the client.
@yordis yordis merged commit c841f11 into ueberauth:master May 5, 2022
@yordis
Copy link
Member

yordis commented May 5, 2022

🚀 thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants