don't close when auth fails #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janthurau
previously approved these changes
May 22, 2023
janthurau
force-pushed
the
fix-disconnect-multiplex
branch
from
fd68ac7
to
e9537cd
Compare
|
I've just rebased this to the latest changes (ClientConnection etc.). Just not sure what I want to do with it, as it changes the behavior of errors in onLoadDocument (terminate connection vs. just sending 'permission denied'). Not sure if that might break something for someone? 🤔 |
janthurau
force-pushed
the
fix-disconnect-multiplex
branch
from
98a4c60
to
868369f
Compare
…n an error is thrown in onLoadDocument)
janthurau
force-pushed
the
fix-disconnect-multiplex
branch
from
868369f
to
e65fd97
Compare
|
ok, LGTM. |
janthurau
approved these changes
Aug 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes and tests #579
There was a test for this already in place, but the issue only occured when first connecting with an invalid token, and then connecting with a valid token. In that case the connection wouldn't be established.
To resolve this, I decided to remove the closing behavior all together. For this, the other test ("stops when the onAuthenticate hook throws an Error") has also been updated