fix: hocuspocus provider auto connect and disconnect behavior #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linspw
commented
Jul 29, 2023
linspw
commented
Jul 29, 2023
linspw
commented
Jul 29, 2023
linspw
commented
Jul 29, 2023
janthurau
pushed a commit
to YousefED/hocuspocus
that referenced
this pull request
Aug 12, 2023
…osis#663) * fix: hocuspocus provider auto connect and disconnect behavior * docs: subdocuments * docs: add documentation for preseveConnection * fix: change name of property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everything is fine?
First I want to thank you for this amazing lib! It has been very useful and if you allow me, I want to be able to contribute a little to it.
In this PR I'm fixing the auto connect flag and adjusting it to pass data to websocket.
I also adjusted some playground stuff.
Please let me know if something doesn't make sense or is wrong.
I thank the attention.