Always clean up connection listeners #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canadaduane
commented
Aug 9, 2023
The Connection class always adds websocket listeners but only conditionally removes them on close. This results in event listener leakage. Instead, we should always remove these listeners when the Connection is closed.
canadaduane
force-pushed
the
cleanup-connection-listeners
branch
from
7c27e15
to
ad4871c
Compare
|
I'm getting a similar message, is it because of this?
|
Yes! That's the same warning message we were seeing. |
|
hmm, not sure if this will fix the warning (as we will still add one listener per document), and I don't see how we can delete connections without matching this condition. I think the warning will only be fixed by #671 , but still happy to merge this :-) THX! |
janthurau
approved these changes
Aug 12, 2023
janthurau
pushed a commit
to YousefED/hocuspocus
that referenced
this pull request
Aug 12, 2023
The Connection class always adds websocket listeners but only conditionally removes them on close. This results in event listener leakage. Instead, we should always remove these listeners when the Connection is closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Connection class always adds websocket listeners but only conditionally removes them on close. This results in event listener leakage. Instead, we should always remove these listeners when the Connection is closed.