Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the debounce argument used to debounce
onStoreDocument
is ignored when the last client for a document disconnects.However if your
onStoreDocument
call is rate limited this means that a client can DOS your server by repeatedly opening and closing a document, preventing storage of it.From what I can see we don't actually need to run this immediately as the unload happens after
onStoreDocument
only if there are still no connections.