Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server/examples.md: Remove outdated documentName references #706

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

raineorshine
Copy link
Contributor

@raineorshine raineorshine commented Sep 26, 2023

I've reviewed the handleConnection interface, and I don't see anywhere that documentName is used. Was this part of a previous version? I think this is no longer needed, but correct me if I'm wrong.

I actually tried out the express example, and it did not work with /:documentName, but it worked when I removed it.

@janthurau janthurau merged commit 0ca2046 into ueberdosis:main Sep 27, 2023
3 checks passed
@raineorshine raineorshine deleted the patch-8 branch October 15, 2023 19:13
TalhaASiddiqi pushed a commit to educative/hocuspocus that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants