Efficiently route messages through HocuspocusProviderWebsocket #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to test in the playground and my app, but it should be okay. Ended up being a very simple change. |
raineorshine
force-pushed
the
websocket-onmessage
branch
from
8bf4c30
to
80a76c7
Compare
raineorshine
commented
Oct 16, 2023
|
Works great in my app, and seems to be working in the playground (other than the Awareness section which is broken in I haven't done any measurements, but in my app this results in a massive reduction in client-side memory usage when many Docs are synced at once. Completely fixed the out-of-memory error that was crashing my web worker. Ready for review/merge. |
|
Thanks a lot for this! Looks great, will do a round of testing as well and then get this merged 😎 |
janthurau
approved these changes
Oct 16, 2023
TalhaASiddiqi
pushed a commit
to educative/hocuspocus
that referenced
this pull request
Feb 1, 2024
…dosis#727) * Efficiently route messages through HocuspocusProviderWebsocket (ueberdosis#724). * HocuspocusProviderWebsocket: Use peekVarString to check documentName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the provider's onMessage running time from O(n) to O(1), where n is the number of all attached providers. It does this by adding a Map to the
HocuspocusProviderWebsocketconfiguration that allows O(1) lookup of attached providers by document name. It will then manually call onMessage on the appropriate provider and only that provider.Fixes #724