Overlapping marks generate invalid HTML

[adrichel]

Hello,

there seems to be an issue with the Tiptap JSON to HTML conversion when using overlapping styles like this:

JSON input:

{
  "type": "doc",
  "content": [
    {
      "type": "paragraph",
      "content": [
        {
          "type": "text",
          "marks": [
            {
              "type": "bold"
            }
          ],
          "text": "lorem "
        },
        {
          "type": "text",
          "marks": [
            {
              "type": "bold"
            },
            {
              "type": "italic"
            }
          ],
          "text": "ipsum"
        },
        {
          "type": "text",
          "marks": [
            {
              "type": "italic"
            }
          ],
          "text": " dolor"
        }
      ]
    }
  ]
}

HTML output:

<p><strong>lorem <em>ipsum</strong> dolor</em></p>

Expected HTML output:

<p><strong>lorem <em>ipsum</em></strong><em> dolor</em></p>

For easy reproduction:

(new Tiptap\Editor)
  ->setContent([
      "type" => "doc",
      "content" => [
          [
              "type" => "paragraph",
              "content" => [
                  [
                      "type" => "text",
                      "marks" => [
                          [
                              "type" => "bold"
                          ]
                      ],
                      "text" => "lorem "
                  ],
                  [
                      "type" => "text",
                      "marks" => [
                          [
                              "type" => "bold"
                          ],
                          [
                              "type" => "italic"
                          ]
                      ],
                      "text" => "ipsum"
                  ],
                  [
                      "type" => "text",
                      "marks" => [
                          [
                              "type" => "italic"
                          ]
                      ],
                      "text" => " dolor"
                  ]
              ]
          ]
      ]
  ])
  ->getHTML();

Thanks in advance :)

[helloiamlukas]

Any updates on this?

[hivokas]

Having similar issue.

Expected:

<strong>You can include a link:  </strong><a href="https://example.com"><strong>Example</strong></a>

Actual:

<strong>You can include a link:  <a href="https://example.com">Example</strong></a>

[timoisik]

Fixed with https://github.com/ueberdosis/tiptap-php/releases/tag/1.3.0