Misaligned tags for overlapping marks

[barnslig]

Describe the bug

Hi,

there seems to be an issue with overlapping marks producing incorrect HTML.

The issue is already fixed in ueberdosis/tiptap-php v1.3.0. However, it seems that it needs to be merged manually into Vizy, because updating tiptap-php does not solve the issue.

Related issues and PRs:

• Overlapping marks generate invalid HTML ueberdosis/tiptap-php#33
• fix misaligned tags for overlapping marks ueberdosis/tiptap-php#37

Possibly affected function that needs to be fixed:

vizy/src/services/Nodes.php

Lines 114 to 152 in 69b8c72

	public function renderNode(NodeInterface $node, ?NodeInterface $prevNode = null, ?NodeInterface $nextNode = null): string
	{
	$html = [];
	if ($node->marks) {
	foreach ($node->marks as $mark) {
	if ($this->markShouldOpen($mark, $prevNode)) {
	$html[] = $mark->renderOpeningTag();
	}
	}
	}
	$html[] = $node->renderOpeningTag();
	if ($node->content) {
	foreach ($node->content as $index => $nestedNode) {
	$prevNestedNode = $node->content[$index - 1] ?? null;
	$nextNestedNode = $node->content[$index + 1] ?? null;
	$html[] = $this->renderNode($nestedNode, $prevNestedNode, $nextNestedNode);
	}
	} else if ($text = $node->getText()) {
	$html[] = $text;
	}
	if (!$node->selfClosing()) {
	$html[] = $node->renderClosingTag();
	if ($node->marks) {
	foreach (array_reverse($node->marks) as $mark) {
	if ($this->markShouldClose($mark, $nextNode)) {
	$html[] = $mark->renderClosingTag();
	}
	}
	}
	}
	return implode($html);
	}

Best regards

Steps to reproduce

Manual issue reproduction:

1. Create a link within a Vizy field
2. Create a text selection that overlaps linked and non-linked text
3. Turn it italic

Example JSON from .getRawNodes():

[{"type":"paragraph","attrs":[],"content":[{"type":"text","text":"Lorem "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https:\/\/google.com","target":"","class":null}}],"text":"ipsum dolor "},{"type":"text","marks":[{"type":"link","attrs":{"href":"https:\/\/google.com","target":"","class":null}},{"type":"italic"}],"text":"sit amet"},{"type":"text","marks":[{"type":"italic"}],"text":", "},{"type":"text","text":"consectetur."}]}]

Rendered invalid HTML from Vizy:

<p>Lorem <a href="https://google.com">ipsum dolor </a><a href="https://google.com"><em>sit amet</a>, </em>consectetur.</p>

Expected HTML, rendered via tiptap-php:

<p>Lorem <a href="https://google.com">ipsum dolor <em>sit amet</em></a><em>, </em>consectetur.</p>

Craft CMS version

Craft Pro 4.4.17

Plugin version

2.1.8

Multi-site?

No response

Additional context

No response

[engram-design]

Fixed for the next release. To get this early, run composer require verbb/vizy:"dev-craft-4 as 2.1.8"

[engram-design]

Fixed in 2.1.9