revert: remove 'whenNotEditable' as option for openOnClick" (#5040)

This reverts commit 0f41e38. Co-authored-by: Nick Perez <nicholas.perez@tiptap.dev>
ueberdosis · May 24, 2024 · ef635db · ef635db
1 parent e95140c
commit ef635db
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 15 deletions.
diff --git a/docs/api/marks/link.md b/docs/api/marks/link.md
@@ -65,14 +65,6 @@ Link.configure({
 })
 ```
 
-If set to `'whenNotEditable'`, links will be opened on click only when editor is not editable.
-
-```js
-Link.configure({
-  openOnClick: 'whenNotEditable',
-})
-```
-
 ### linkOnPaste
 Adds a link to the current selection if the pasted content only contains an url.
 

diff --git a/packages/extension-link/src/helpers/clickHandler.ts b/packages/extension-link/src/helpers/clickHandler.ts
@@ -3,18 +3,14 @@ import { MarkType } from '@tiptap/pm/model'
 import { Plugin, PluginKey } from '@tiptap/pm/state'
 
 type ClickHandlerOptions = {
-  type: MarkType,
-  whenNotEditable: boolean,
+  type: MarkType
 }
 
 export function clickHandler(options: ClickHandlerOptions): Plugin {
   return new Plugin({
     key: new PluginKey('handleClickLink'),
     props: {
       handleClick: (view, pos, event) => {
-        if (options.whenNotEditable && view.editable) {
-          return false
-        }
         if (event.button !== 0) {
           return false
         }

diff --git a/packages/extension-link/src/link.ts b/packages/extension-link/src/link.ts
@@ -48,7 +48,7 @@ export interface LinkOptions {
    * @example false
    * @example 'whenNotEditable'
    */
-  openOnClick: boolean | 'whenNotEditable'
+  openOnClick: boolean
   /**
    * Adds a link to the current selection if the pasted content only contains an url.
    * @default true
@@ -264,7 +264,6 @@ export const Link = Mark.create<LinkOptions>({
       plugins.push(
         clickHandler({
           type: this.type,
-          whenNotEditable: this.options.openOnClick === 'whenNotEditable',
         }),
       )
     }