fix(core): fix options now being empty

ueberdosis · Nov 30, 2023 · fc67cb1 · fc67cb1
1 parent fab5e96
commit fc67cb1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/core/src/Extension.ts b/packages/core/src/Extension.ts
@@ -297,7 +297,7 @@ export class Extension<Options = any, Storage = any> {
 
   config: ExtensionConfig = {
     name: this.name,
-    defaultOptions: undefined,
+    defaultOptions: {},
   }
 
   constructor(config: Partial<ExtensionConfig<Options, Storage>> = {}) {
@@ -308,7 +308,7 @@ export class Extension<Options = any, Storage = any> {
 
     this.name = this.config.name
 
-    if (config.defaultOptions) {
+    if (config.defaultOptions && Object.keys(config.defaultOptions).length > 0) {
       console.warn(
         `[tiptap warn]: BREAKING CHANGE: "defaultOptions" is deprecated. Please use "addOptions" instead. Found in extension: "${this.name}".`,
       )

diff --git a/packages/core/src/Mark.ts b/packages/core/src/Mark.ts
@@ -429,7 +429,7 @@ export class Mark<Options = any, Storage = any> {
 
   config: MarkConfig = {
     name: this.name,
-    defaultOptions: undefined,
+    defaultOptions: {},
   }
 
   constructor(config: Partial<MarkConfig<Options, Storage>> = {}) {
@@ -440,7 +440,7 @@ export class Mark<Options = any, Storage = any> {
 
     this.name = this.config.name
 
-    if (config.defaultOptions) {
+    if (config.defaultOptions && Object.keys(config.defaultOptions).length > 0) {
       console.warn(
         `[tiptap warn]: BREAKING CHANGE: "defaultOptions" is deprecated. Please use "addOptions" instead. Found in extension: "${this.name}".`,
       )

diff --git a/packages/core/src/Node.ts b/packages/core/src/Node.ts
@@ -538,7 +538,7 @@ export class Node<Options = any, Storage = any> {
 
   config: NodeConfig = {
     name: this.name,
-    defaultOptions: undefined,
+    defaultOptions: {},
   }
 
   constructor(config: Partial<NodeConfig<Options, Storage>> = {}) {
@@ -549,7 +549,7 @@ export class Node<Options = any, Storage = any> {
 
     this.name = this.config.name
 
-    if (config.defaultOptions) {
+    if (config.defaultOptions && Object.keys(config.defaultOptions).length > 0) {
       console.warn(
         `[tiptap warn]: BREAKING CHANGE: "defaultOptions" is deprecated. Please use "addOptions" instead. Found in extension: "${this.name}".`,
       )