Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CollaborationCursor history not working together with BubbleMenu component #2827

Closed
1 of 2 tasks
ArminasTelesoftas opened this issue May 25, 2022 · 3 comments
Closed
1 of 2 tasks
Labels
Type: Bug The issue or pullrequest is related to a bug

Comments

@ArminasTelesoftas
Copy link

What’s the bug you are facing?

CollaborationCursor extension comes in with its own history and its working as expected until I've added <BubbleMenu /> component.

I tried dropping <BubbleMenu /> component and used BubbleMenu extension from @tiptap/extension-bubble-menu instead and history started working as expected again. But I would prefer to use <BubbleMenu /> component.

Worth mentioning that I've disabled history extension from StarterKit, otherwise it produces following warning:

index.js:27 [tiptap warn]: "@tiptap/extension-collaboration" comes with its own history support and is not compatible with "@tiptap/extension-history".

Which browser was this experienced in? Are any special extensions installed?

Chrome, Firefox. No special extensions.

How can we reproduce the bug on our side?

Try using history options editor.chain().focus().undo().run() or editor.chain().focus().redo().run() from CollaborationCursor together with <BubbleMenu /> component. History should not work.

Comment out <BubbleMenu /> and history should work again.

Can you provide a CodeSandbox?

https://codesandbox.io/s/sad-chaum-ti1296?file=/src/_app.js

What did you expect to happen?

I have expected that history functions should work as described.

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@ArminasTelesoftas ArminasTelesoftas added the Type: Bug The issue or pullrequest is related to a bug label May 25, 2022
@ArminasTelesoftas
Copy link
Author

Just found related issue which is more detailed

@stale
Copy link

stale bot commented Jul 24, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@svenadlung
Copy link
Contributor

Only for the sake of completeness: We released the fix in 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug The issue or pullrequest is related to a bug
Projects
None yet
Development

No branches or pull requests

2 participants