Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table toggleHeaderColumn doesn't unset first cell if there is one column (same with row) #3899

Open
1 of 2 tasks
alexeyivanov94 opened this issue Mar 28, 2023 · 1 comment
Open
1 of 2 tasks

Table toggleHeaderColumn doesn't unset first cell if there is one column (same with row) #3899

alexeyivanov94 opened this issue Mar 28, 2023 · 1 comment
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug
Milestone
2.1.0 Release

Comments

@alexeyivanov94
Copy link

What’s the bug you are facing?

If table have one column toggleHeaderColumn set header cells correctly. But if we try to unset, its doesn't applies for the first cell (same with row)

Which browser was this experienced in? Are any special extensions installed?

Any

How can we reproduce the bug on our side?

Can be reproduce at docs example

  1. Remove all rows/columns
  2. Toggle header row/column multiple times

Can you provide a CodeSandbox?

No response

What did you expect to happen?

Method should toggle all cells in a row/column

Anything to add? (optional)

No response

Did you update your dependencies?

  • Yes, I’ve updated my dependencies to use the latest version of all packages.

Are you sponsoring us?

  • Yes, I’m a sponsor. 💖
@alexeyivanov94 alexeyivanov94 added the Type: Bug The issue or pullrequest is related to a bug label Mar 28, 2023
@alexeyivanov94 alexeyivanov94 changed the title Table toggleHeaderColumn doesn't unset first cell if there is one column (same for row) Table toggleHeaderColumn doesn't unset first cell if there is one column (same with row) Mar 28, 2023
@bdbch bdbch added Triage: Open A new issue or pullrequest that requires triage (added by default) Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. labels Mar 29, 2023
@bdbch
Copy link
Contributor

bdbch commented Mar 29, 2023

Thanks for the issue. I was able to reproduce it and will add it to the todo list.

@bdbch bdbch added this to the 2.1.0 Release milestone Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Category: Open Source The issue or pull reuqest is related to the open source packages of Tiptap. Triage: Open A new issue or pullrequest that requires triage (added by default) Type: Bug The issue or pullrequest is related to a bug
Projects
Tiptap
Status: Triage open
Milestone
2.1.0 Release
Development

No branches or pull requests
2 participants
@bdbch @alexeyivanov94