Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better types for Vue 2 #1253

Merged
merged 1 commit into from May 4, 2021
Merged

feat: better types for Vue 2 #1253

merged 1 commit into from May 4, 2021

Conversation

zcuric
Copy link
Contributor

@zcuric zcuric commented May 3, 2021

This PR

  • Removes Vue.extend in vue@2 specific components and provides better custom types
  • Closes $attrs is readonly. #1219
  • Solves choking the browser issues that can happen in certain scenariors

PR was tested locally.

@zcuric
Copy link
Contributor Author

zcuric commented May 3, 2021

@philippkuehn Please review :)

@philippkuehn philippkuehn merged commit a96e0c2 into ueberdosis:main May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$attrs is readonly.
2 participants